1523931 - No longer creating accessibles for blank lines in Gmail

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Marco Zehe (:MarcoZ)]

Regression from bug 646216. STR, with NVDA:

1. Log into Gmail.
2. Compose a new message.
3. Type something in line 1.
4. Press Enter twice.
5. Type some more text.
6. Navigate up.

Expected: NVDA should indicate the blank line.

Actual: NVDA reads text from the first line.

The reason is that the accessible no longer gets created for the blank div.

Reduced test case:
data:text/html,<div contentEditable="true"><div>Testing a blank line.</div><div></div><div>And another</div></div>

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1523931 - Always create accessibles for div elements if they contain a br element, r=Jamie

After the fix for bug 646216, we no longer create divs with no text if the previous and next siblings are divs that contain text. This breaks blank lines in contentEditables such as Gmail.

To fix, always create accessibles for divs if such a div is part of a contentEditable subtree.

Comment 2

[Marco Zehe (:MarcoZ)]

After discussion, it turns out the fix needs to be broader and we must render divs if they contain a br element. Updated patch addresses that, and became much simpler in the process.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/188cd38b99f0
Always create accessibles for div elements if they contain a br element, r=Jamie

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/188cd38b99f0