Collapse a11y tree when possible
Categories
(Core :: Disability Access APIs, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: fherrera, Assigned: MarcoZ)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
867 bytes,
patch
|
Details | Diff | Splinter Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Comment 1•14 years ago
|
||
Comment 2•14 years ago
|
||
Comment 3•14 years ago
|
||
Comment 4•8 years ago
|
||
Comment 5•8 years ago
|
||
Comment 6•7 years ago
|
||
Comment 7•7 years ago
|
||
Assignee | ||
Comment 8•7 years ago
|
||
Comment 9•7 years ago
|
||
Assignee | ||
Comment 10•7 years ago
|
||
Comment 11•7 years ago
|
||
Assignee | ||
Comment 12•7 years ago
|
||
Comment 13•7 years ago
|
||
Comment 14•7 years ago
|
||
Comment 15•7 years ago
|
||
Comment 16•7 years ago
|
||
Comment 17•7 years ago
|
||
Assignee | ||
Comment 18•6 years ago
|
||
Assignee | ||
Comment 19•6 years ago
|
||
Assignee | ||
Comment 20•6 years ago
|
||
Relevant divs are:
- Those that have an ID attribute. This is important so anchors still work.
- Those whose first or last child is a text-only node.
- Those whose first or last child has an inline frame.
- Those whose descendants contain an img tag.
Assignee | ||
Comment 21•6 years ago
|
||
Updated•6 years ago
|
Comment 22•6 years ago
|
||
Comment 23•6 years ago
|
||
backed out for failing bc at browser_treeupdate_cssoverflow.js
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=224597838&repo=autoland&lineNumber=1308
Backout: https://hg.mozilla.org/integration/autoland/rev/496e97dab12cfabdda89bcffa334f201471b8285
Comment 24•6 years ago
|
||
Assignee | ||
Comment 25•6 years ago
|
||
Landed with fixed test. The fix was the same as for the similarly named mochitest.
Comment 26•6 years ago
|
||
bugherder |
Comment 27•6 years ago
|
||
I think there's a problem with the taken approach, which is you handle tree updates properly, i.e. you don't rebuilt a tree if a reduced tree is altered. Say, if you have denied to create an accessible for a div in <h1><div></div></h1>, and then JS inserts a <span>hey</span> as a first child of <h1>, according to logic in MARKUPMAP(div), div has to be accessible now, but it doens't happen.
Assignee | ||
Comment 28•6 years ago
|
||
Any suggestions where to handle this, Alex?
Comment 29•6 years ago
|
||
(In reply to Marco Zehe (:MarcoZ) from comment #28)
Any suggestions where to handle this, Alex?
I agreed that cutting the number of elements in accessible tree looks very tempting, but it goes at cost of the tree update, of course if we do this. So, if update the tree part can be skipped, i.e. no one is regressed in the wilds (I guess you can be certain on this when the patch is shipped on release build), then we are in good shape I'd say. Otherwise, we would need to implement update the tree part, however it will go at performance cost. Thus it'd be good to improve our talos coverage.
Anyway, I'd say this is something that is good to work on with other browsers vendors to make sure the accessible tree we expose is consistent though the browsers. Maybe HTML-AAM can be a good platform to keep discussion on.
Cc'ing Aaron
Description
•