1524123 - Search alias results should use engine favicons, not the magnifying glass

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Drew Willcoxon :adw]

In the legacy popup, search alias results use engine favicons, not the magnifying glass used in quantumbar.

Comment 1

[Dão Gottwald [:dao]]

This was an intentional change in bug 1512660.

Comment 2

[Mark Banner (:standard8)]

Tagging as nightly, as I think we should have at least a resolution here so we know what to tell QA to expect.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

let's just restore the icon for search engines, where it's trivial. Keywords is more complex, it would be nice if we could either have a favicon or glass, but that requires doing an additional fetch. probably it would be better if the page-icon protocol would accept an override default icon url, but that should happen elsewhere.

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1524123 - Use engine favicons if available instead of the magnifying glass. r=adw

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/234d39cb0426
Use engine favicons if available instead of the magnifying glass. r=adw

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/234d39cb0426

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I filed bug 1528196 to allow page-icon to return an alternative default favicon.