1524450 - External Protocol Service cannot be unregistered for tests

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

In shared-modules/test-content-tab-helpers.js, we mock the external protocol service so we can test clicking on links. This is broken:

var contract = "@mozilla.org/uriloader/external-protocol-service;1";
var cid = Components.manager.contractIDToCID(contract);
var classObj = Components.manager.getClassObject(cid, Ci.nsIFactory);
Components.manager.unregisterFactory(cid, classObj);

[Exception... "Component returned failure code: 0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED) [nsIComponentRegistrar.unregisterFactory]"  nsresult: "0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED)"  location: "JS frame :: debugger eval code :: <TOP_LEVEL> :: line 1"  data: no]

I'm disabling a test in newmailaccount/test-newmailaccount.js. There's one in cloudfile/test-cloudfile-manager.js too, which is already disabled for bug 1522778.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b6cc6a64d219
Disable tests that require mocking External Protocol Service; rs=bustage-fix

Comment 2

[Magnus Melin [:mkmelin]]

Do we know what regressed this?

Comment 3

[Jorg K (CEST = GMT+2)]

Hard to tell after four days of bustage.

Comment 4

[Geoff Lankow (:darktrojan)]

I clearly forgot to mention this is also the case in Firefox but they obviously don't try to do it or there'd be broken tests.

Comment 5

[Jorg K (CEST = GMT+2)]

Geoff, can you give some STR for FF and then NI Alice ([e-mail]) to kindly find the regression for us.

Comment 6

[Geoff Lankow (:darktrojan)]

Run the code from comment 0 in the developer tools.

Comment 7

[Jorg K (CEST = GMT+2)]

Alice, can you please find regression with the code in comment #0. Thanks in advance.

Comment 8

[Alice0775 White]

Open Browser Console
Paste the following code and press ENTER key

var contract = "@mozilla.org/uriloader/external-protocol-service;1";
var cid = Components.manager.contractIDToCID(contract);
var classObj = Components.manager.getClassObject(cid, Ci.nsIFactory);
Components.manager.unregisterFactory(cid, classObj);

No error on Firefox65.
Error on Nightly67.0a1.

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=91f5131e326ad99acb9a44567c9c08d3d1f8b06b&tochange=7ea334118c82e3609be2a1cfa3c5b867017c4937

Comment 9

[Jorg K (CEST = GMT+2)]

Kris, this is not intentional, is it? What can be done to restore this function?

Comment 10

[Kris Maglione [:kmag]]

It is intentional, yes. Static components cannot be unregistered. You can override them by registering a new component with the same contract ID, though.

Comment 11

[Jorg K (CEST = GMT+2)]

Thanks, Kris. Moving this back to the TB queue.

Comment 12

[Geoff Lankow (:darktrojan)]

Should I be able to unregister the override? unregisterFactory doesn't complain, but if I then try to get the original service (e.g. in the next test) NS_ERROR_XPC_GS_RETURNED_FAILURE is thrown.

Comment 13

[Geoff Lankow (:darktrojan)]

Attachment: 1524450-enable-tests-1.diff

Bug 1528437 fixed this.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4ba6ad8570e5
Backed out changeset b6cc6a64d219 to re-enable tests fixed by bug 1528437. a=backout

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/30a29ea45d4f
Really re-enable test fixed by bug 1528437. a=backout