Closed Bug 1524561 Opened 1 year ago Closed 1 year ago

[Accessibility] Quantumbar results popup has no accessibility semantics

Categories

(Firefox :: Address Bar, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: MarcoZ, Assigned: dao)

References

Details

Attachments

(1 file)

The HTML for the results popup is lacking all kinds of proper semantics. Right now, it is only div and span elements without telling assistive technologies what is which.

Blocks: 1524564
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Priority: -- → P1
Depends on: 1525269

Comment on attachment 9049118 [details]
Bug 1524561 - Quantumbar: add accessibility semantics.

This is what I have so far. I think it's not quite there yet. E.g. I'm not sure where role="combobox", aria-owns, and aria-controls should be set (I don't even understand the difference between the latter two). Right now I'm setting them on the anonymous input field and I'm not sure if that works at all.

Attachment #9049118 - Flags: feedback?(mzehe)

Comment on attachment 9049118 [details]
Bug 1524561 - Quantumbar: add accessibility semantics.

See comments in Phabricator.

Attachment #9049118 - Flags: feedback?(mzehe) → feedback+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a299cc84703a
Quantumbar: add accessibility semantics. r=mak
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.