1524564 - [Accessibility] arrowing among search results does not generate any accessibility events

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Marco Zehe (:MarcoZ)]

STR (with NVDA):

1. Enable quantumbar.
2. Type in something into the address bar that will result in the popup being shown.
3. Press Up and Down arrows.

Expected: I should hear the results.
Actual: Focus remains in the address bar, and only the newly replaced URL is read.

Comment 1

[Tim Nguyen :ntim]

It doesn't seem related to bug 1520440, I guess you meant bug 1522440 :)

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1524564 - Set aria-activedescendant on the input rather than the view so the input delegates a11y focus. r?mak,Standard8

Comment 3

[Mark Banner (:standard8)]

Marco, James, do you know if browser_test_focus_urlbar.js covers the functionality we're fixing here?

I'm trying to work out if we need an additional test for this (and what it should look like).

Comment 4

[Marco Zehe (:MarcoZ)]

In theory, it should. What we're trying to get at is that, when you type something, then press DownArrow, focus goes onto the first selected option. Accessibility focus, that is, the thing that gets set via aria-activedescendant. And that is definitely covered by tests. Likewise, if you hit left or right arrow, focus should go back to the edit box, e. g. aria-activedescendant should be removed. The tests cover prety thoroughly the cases we normally encounter when interacting with the keyboard. The new QuantumBar should behave in the same manner, e. g. emit the same accessibility events if possible.

So yes, this test is pretty thorough in what it covers. Right now, as in the latest Nightly with the fix for bug 1524561, it still behaves as before, e. g. up and down arrows simply speak the updated text in the edit box itself, not the actual result that has been selected.

Comment 5

[Mark Banner (:standard8)]

Thanks for the response. We'll get this patch landed.

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4619f517e391

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/4619f517e391d5bfa81d27936a2d0c080e8a90bc