Closed Bug 1524687 Opened 5 years ago Closed 5 years ago

Migrate long tail of component registrations to static manifests

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla67

Tracking Flags:

Tracking

Status

firefox67

---

fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

Attachments

(13 files)

Bug 1524687 - Part 0: Fix more dodgy component mocking code. r=froydnj 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1524687: Part 1 - Convert PaymentRequestModule to static manifest. r=edenchuang 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1524687: Part 2 - Convert most of the embedding module to static registration. r=mossop 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1524687: Part 3 - Convert nsImageModule to static registration. r=jwatt 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1524687: Part 4 - Convert Places module to static registration. r=mak 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1524687: Part 5 - Convert JAR module to static registration. r=valentin 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1524687: Part 6 - Convert intl modules to static registration. r=zbraniecki 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1524687: Part 7 - Convert media bridge module to static registration. r=jesup 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1524687: Part 8 - Convert remaining toolkit modules to static registration. r=mossop 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1524687: Part 9 - Convert gtk widget module to static registration. r=erahm 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1524687: Part 10 - Convert Windows widget module to static registration. r=erahm 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1524687: Part 11 - Convert browser modules to static registration. r=mossop 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1524687: Part 12 - Convert everything else to static registration. r=erahm 5 years ago Kris Maglione [:kmag] 47 bytes, text/x-phabricator-request		Details \| Review

Kris Maglione [:kmag]

Assignee

Description

•

5 years ago

Bug 1478124 took care of migrating the larger modules, but the long tail of smaller modules still accounts for well over a hundred components. Migrating them will save us a few tens of KB per process.

Kris Maglione [:kmag]

Assignee

Comment 1

•

5 years ago

Attached file Bug 1524687 - Part 0: Fix more dodgy component mocking code. r=froydnj — Details

Kris Maglione [:kmag]

Assignee

Comment 2

•

5 years ago

Attached file Bug 1524687: Part 1 - Convert PaymentRequestModule to static manifest. r=edenchuang — Details

Kris Maglione [:kmag]

Assignee

Comment 3

•

5 years ago

Attached file Bug 1524687: Part 2 - Convert most of the embedding module to static registration. r=mossop — Details

Kris Maglione [:kmag]

Assignee

Comment 4

•

5 years ago

Attached file Bug 1524687: Part 3 - Convert nsImageModule to static registration. r=jwatt — Details

Kris Maglione [:kmag]

Assignee

Comment 5

•

5 years ago

Attached file Bug 1524687: Part 4 - Convert Places module to static registration. r=mak — Details

Kris Maglione [:kmag]

Assignee

Comment 6

•

5 years ago

Attached file Bug 1524687: Part 5 - Convert JAR module to static registration. r=valentin — Details

Kris Maglione [:kmag]

Assignee

Comment 7

•

5 years ago

Attached file Bug 1524687: Part 6 - Convert intl modules to static registration. r=zbraniecki — Details

Kris Maglione [:kmag]

Assignee

Comment 8

•

5 years ago

Attached file Bug 1524687: Part 7 - Convert media bridge module to static registration. r=jesup — Details

Kris Maglione [:kmag]

Assignee

Comment 9

•

5 years ago

Attached file Bug 1524687: Part 8 - Convert remaining toolkit modules to static registration. r=mossop — Details

Kris Maglione [:kmag]

Assignee

Comment 10

•

5 years ago

Attached file Bug 1524687: Part 9 - Convert gtk widget module to static registration. r=erahm — Details

Kris Maglione [:kmag]

Assignee

Comment 11

•

5 years ago

Attached file Bug 1524687: Part 10 - Convert Windows widget module to static registration. r=erahm — Details

Kris Maglione [:kmag]

Assignee

Comment 12

•

5 years ago

Attached file Bug 1524687: Part 11 - Convert browser modules to static registration. r=mossop — Details

Kris Maglione [:kmag]

Assignee

Comment 13

•

5 years ago

Attached file Bug 1524687: Part 12 - Convert everything else to static registration. r=erahm — Details

:Felipe Gomes (needinfo for replies!)

Updated

•

5 years ago

Blocks: 1525100

Kris Maglione [:kmag]

Assignee

Comment 14

•

5 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/e96e61bd282f3f6261709ba6cdc473713dadacb7
Bug 1524687 - Part 0: Fix more dodgy component mocking code. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/219b84a58f506a6b42d23f234e6a8f32e3c3da6c
Bug 1524687: Part 1 - Convert PaymentRequestModule to static manifest. r=edenchuang

https://hg.mozilla.org/integration/mozilla-inbound/rev/10c69df4444dd5b5410ea8716404c14721afa925
Bug 1524687: Part 2 - Convert most of the embedding module to static registration. r=mossop

https://hg.mozilla.org/integration/mozilla-inbound/rev/df95a56dae044a9d8c6a5b449b2c6db4365806b7
Bug 1524687: Part 3 - Convert nsImageModule to static registration. r=jwatt

https://hg.mozilla.org/integration/mozilla-inbound/rev/c58caf41bb942d24efb5e108cdb7811be2930498
Bug 1524687: Part 4 - Convert Places module to static registration. r=mak

https://hg.mozilla.org/integration/mozilla-inbound/rev/191afe83da2e062951a2740d7cab68cf563ecfc7
Bug 1524687: Part 5 - Convert JAR module to static registration. r=valentin

https://hg.mozilla.org/integration/mozilla-inbound/rev/f4ee175bc5bda170021c09456819bc9daeea6408
Bug 1524687: Part 6 - Convert intl modules to static registration. r=zbraniecki

https://hg.mozilla.org/integration/mozilla-inbound/rev/92d9e927deec9628ddbde16238debccc10b93b3b
Bug 1524687: Part 7 - Convert media bridge module to static registration. r=jesup

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9862758b98ccb95e90901258bcea159784c7483
Bug 1524687: Part 8 - Convert remaining toolkit modules to static registration. r=mossop

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c24919ac5c2056255dec5725af1fa1548f29ca2
Bug 1524687: Part 9 - Convert gtk widget module to static registration. r=erahm

https://hg.mozilla.org/integration/mozilla-inbound/rev/614be688767fed0d16362dc5fbf0d34fc3c65579
Bug 1524687: Part 10 - Convert Windows widget module to static registration. r=erahm

https://hg.mozilla.org/integration/mozilla-inbound/rev/46e13c453538f73dd063284804582e5f74c1432a
Bug 1524687: Part 11 - Convert browser modules to static registration. r=mossop

https://hg.mozilla.org/integration/mozilla-inbound/rev/625f71135038f79c075f758e316fbb00097c9a18
Bug 1524687: Part 12 - Convert everything else to static registration. r=erahm

Kris Maglione [:kmag]

Assignee

Comment 15

•

5 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/68cffca6927a90ace041bd3f938954fab0d0c586
Bug 1524687: Follow-up: Fix sporadic Windows PGO build bustages. r=bustage CLOSED TREE

Kris Maglione [:kmag]

Assignee

Comment 16

•

5 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/68a001a424062bc60dd8ed56ae263162f1d56d6c
Bug 1524687: Follow-up: Work around continued sporatic Windows PGO bustage. r=bustage

Natalia Csoregi [:nataliaCs]

Comment 17

•

5 years ago

Backed out for crashes on mozilla::dom::ScreenOrientation::ScreenOrientation(nsPIDOMWindowInner *,nsScreen *)

backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/3b1b94e39795d5af17da5908ad8d05e7cefb89e5

push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=68a001a424062bc60dd8ed56ae263162f1d56d6c&searchStr=windows%2C7%2Cpgo&selectedJob=228353815

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228356198&repo=mozilla-inbound&lineNumber=1534

09:21:50 INFO - PROCESS-CRASH | Main app process exited normally | application crashed [@ mozilla::dom::ScreenOrientation::ScreenOrientation(nsPIDOMWindowInner *,nsScreen *)]
09:21:50 INFO - Crash dump filename: c:\users\task_1550133498\appdata\local\temp\tmpkeasgm.mozrunner\minidumps\0978fde2-7738-4951-bd9b-a5bcfbf7b474.dmp
09:21:50 INFO - Operating system: Windows NT
09:21:50 INFO - 10.0.17134
09:21:50 INFO - CPU: amd64
09:21:50 INFO - family 6 model 85 stepping 3
09:21:50 INFO - 8 CPUs
09:21:50 INFO -
09:21:50 INFO - GPU: UNKNOWN
09:21:50 INFO -
09:21:50 INFO - Crash reason: EXCEPTION_BREAKPOINT
09:21:50 INFO - Crash address: 0x7fffb2770f28
09:21:50 INFO - Assertion: Unknown assertion type 0x00000000
09:21:50 INFO - Process uptime: 1 seconds
09:21:50 INFO -
09:21:50 INFO - Thread 0 (crashed)
09:21:50 INFO - 0 xul.dll!mozilla::dom::ScreenOrientation::ScreenOrientation(nsPIDOMWindowInner *,nsScreen *) [ScreenOrientation.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 84 + 0xb0]
09:21:50 INFO - rax = 0x00007fffb7650af1 rdx = 0x0000000000000000
09:21:50 INFO - rcx = 0x00007fffea5f1ba0 rbx = 0x000001ede4669678
09:21:50 INFO - rsi = 0x000001ede4669600 rdi = 0x000001ede46feb00
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfc3c0
09:21:50 INFO - r8 = 0x0000000000000018 r9 = 0x0000000000000020
09:21:50 INFO - r10 = 0x00007fffb7607aa4 r11 = 0x0000000000000031
09:21:50 INFO - r12 = 0x000001edde925000 r13 = 0x0000183741180600
09:21:50 INFO - r14 = 0x00007fffb77effb0 r15 = 0x000001edde925000
09:21:50 INFO - rip = 0x00007fffb2770f28
09:21:50 INFO - Found by: given as instruction pointer in context
09:21:50 INFO - 1 xul.dll!nsScreen::nsScreen(nsPIDOMWindowInner *) [nsScreen.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 39 + 0xe]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfc430 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb2770c6c
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 2 xul.dll!nsScreen::Create(nsPIDOMWindowInner *) [nsScreen.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 33 + 0xb]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfc480 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb2770b09
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 3 xul.dll!static bool mozilla::dom::Window_Binding::get_screen(struct JSContext *, class JS::Handle<JSObject *>, class nsGlobalWindowInner *, class JSJitGetterCallArgs) [WindowBinding.cpp: : 4116 + 0x1a]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfc4e0 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb4f503da
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 4 xul.dll!mozilla::dom::binding_detail::GenericGetter<mozilla::dom::binding_detail::MaybeGlobalThisPolicy,mozilla::dom::binding_detail::ThrowExceptions>(JSContext *,unsigned int,JS::Value *) [BindingUtils.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 3040 + 0x9]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfc560 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb25661f6
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 5 xul.dll!js::InternalCallOrConstruct(JSContext *,JS::CallArgs const &,js::MaybeConstruct) [Interpreter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 534 + 0x10a]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfc600 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb2cd97f0
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 6 xul.dll!js::CallGetter(JSContext *,JS::Handle<JS::Value>,JS::Handle<JS::Value>,JS::MutableHandle<JS::Value>) [Interpreter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 729 + 0xa5]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfc6f0 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb2cdaba5
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 7 xul.dll!js::NativeGetProperty(JSContext *,JS::Handle<js::NativeObject *>,JS::Handle<JS::Value>,JS::Handle<JS::PropertyKey>,JS::MutableHandle<JS::Value>) [NativeObject.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 2570 + 0x3db]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfc790 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb2e65070
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 8 xul.dll!js::ForwardingProxyHandler::get(JSContext *,JS::Handle<JSObject *>,JS::Handle<JS::Value>,JS::Handle<JS::PropertyKey>,JS::MutableHandle<JS::Value>) [Wrapper.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 141 + 0x1c]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfc8a0 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb2ff65ce
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 9 xul.dll!bool nsOuterWindowProxy::get(struct JSContext *, class JS::Handle<JSObject *>, class JS::Handle<JS::Value>, class JS::Handle<JS::PropertyKey>, class JS::MutableHandle<JS::Value>) [nsGlobalWindowOuter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 904 + 0x1a]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfc900 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb25657d4
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 10 xul.dll!js::Proxy::get(JSContext *,JS::Handle<JSObject *>,JS::Handle<JS::Value>,JS::Handle<JS::PropertyKey>,JS::MutableHandle<JS::Value>) [Proxy.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 350 + 0x22]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfc9c0 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb2fecdc3
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 11 xul.dll!js::GetProperty(JSContext *,JS::Handle<JS::Value>,JS::Handle<js::PropertyName *>,JS::MutableHandle<JS::Value>) [Interpreter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 4456 + 0x17]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfca90 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb2cdcd90
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 12 xul.dll!static bool Interpret(struct JSContext *, class js::RunState & const) [Interpreter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 2767 + 0xc5]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfcb50 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb2cd26a9
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 13 xul.dll!js::RunScript(JSContext *,js::RunState &) [Interpreter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 422 + 0xb]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfcf20 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb2ccbfa0
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 14 xul.dll!js::ExecuteKernel(JSContext *,JS::Handle<JSScript *>,JSObject &,JS::Value const &,js::AbstractFramePtr,JS::Value *) [Interpreter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 781 + 0x5]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfcfa0 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb2cdaee4
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 15 xul.dll!js::Execute(JSContext *,JS::Handle<JSScript *>,JSObject &,JS::Value *) [Interpreter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 814 + 0x1e]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfd040 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb2cdb05e
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 16 xul.dll!JS::CloneAndExecuteScript(JSContext *,JS::Handle<JSScript *>,JS::MutableHandle<JS::Value>) [CompilationAndEvaluation.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 501 + 0xe]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfd0c0 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb2d76e96
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 17 xul.dll!static bool EvalScript(struct JSContext *, class JS::Handle<JSObject *>, class JS::Handle<JSObject *>, class JS::MutableHandle<JS::Value>, class nsIURI *, bool, bool, class JS::MutableHandle<JSScript *>) [mozJSSubScriptLoader.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 158 + 0xe]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfd140 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb43588e7
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 18 xul.dll!nsresult mozJSSubScriptLoader::DoLoadSubScriptWithOptions(const class nsTSubstring<char16_t> & const, class LoadSubScriptOptions & const, struct JSContext *, class JS::MutableHandle<JS::Value>) [mozJSSubScriptLoader.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 677 + 0x2f]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfd260 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb264626d
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 19 xul.dll!nsresult mozJSSubScriptLoader::LoadSubScript(const class nsTSubstring<char16_t> & const, class JS::Handle<JS::Value>, struct JSContext *, class JS::MutableHandle<JS::Value>) [mozJSSubScriptLoader.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 524 + 0x8]
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfd5a0 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb2645cb2
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 20 xul.dll!XPTC__InvokebyIndex + 0x72
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfd620 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x00007fffb6c96e32
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 21 0x2ad6dfd758
09:21:50 INFO - rbx = 0x000001ede4669678 rbp = 0x000001ede455e800
09:21:50 INFO - rsp = 0x0000002ad6dfd630 r12 = 0x000001edde925000
09:21:50 INFO - r13 = 0x0000183741180600 r14 = 0x00007fffb77effb0
09:21:50 INFO - r15 = 0x000001edde925000 rip = 0x0000002ad6dfd758
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 22 xul.dll!trunc + 0x1aa613
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfd658
09:21:50 INFO - rip = 0x00007fffb6e46e53
09:21:50 INFO - Found by: stack scanning
09:21:50 INFO - 23 xul.dll!trunc + 0x1a8a20
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfd660
09:21:50 INFO - rip = 0x00007fffb6e45260
09:21:50 INFO - Found by: stack scanning
09:21:50 INFO - 24 xul.dll!static bool XPCWrappedNative::CallMethod(class XPCCallContext & const, XPCWrappedNative::CallMode) [XPCWrappedNative.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 1152 + 0x2b5]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfd680
09:21:50 INFO - rip = 0x00007fffb242ad35
09:21:50 INFO - Found by: stack scanning
09:21:50 INFO - 25 xul.dll!static bool XPC_WN_CallMethod(struct JSContext *, unsigned int, union JS::Value *) [XPCWrappedNativeJSOps.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 946 + 0x8]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfd8d0
09:21:50 INFO - rip = 0x00007fffb2429d78
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 26 xul.dll!js::InternalCallOrConstruct(JSContext *,JS::CallArgs const &,js::MaybeConstruct) [Interpreter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 534 + 0x10a]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfda40
09:21:50 INFO - rip = 0x00007fffb2cd97f0
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 27 xul.dll!static bool InternalCall(struct JSContext *, const class js::AnyInvokeArgs & const) [Interpreter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 589 + 0xe]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfdb30
09:21:50 INFO - rip = 0x00007fffb2cda20b
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 28 xul.dll!static bool Interpret(struct JSContext *, class js::RunState & const) [Interpreter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 3066 + 0x15]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfdb90
09:21:50 INFO - rip = 0x00007fffb2cd34b6
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 29 xul.dll!js::RunScript(JSContext *,js::RunState &) [Interpreter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 422 + 0xb]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfdf60
09:21:50 INFO - rip = 0x00007fffb2ccbfa0
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 30 xul.dll!js::InternalCallOrConstruct(JSContext *,JS::CallArgs const &,js::MaybeConstruct) [Interpreter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 562 + 0xd]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfdfe0
09:21:50 INFO - rip = 0x00007fffb2cd99c5
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 31 xul.dll!static bool InternalCall(struct JSContext *, const class js::AnyInvokeArgs & const) [Interpreter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 589 + 0xe]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfe0d0
09:21:50 INFO - rip = 0x00007fffb2cda20b
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 32 xul.dll!js::Call(JSContext *,JS::Handle<JS::Value>,JS::Handle<JS::Value>,js::AnyInvokeArgs const &,JS::MutableHandle<JS::Value>) [Interpreter.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 605 + 0x8]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfe130
09:21:50 INFO - rip = 0x00007fffb2cda254
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 33 xul.dll!JS::Call(JSContext *,JS::Handle<JS::Value>,JS::Handle<JS::Value>,JS::HandleValueArray const &,JS::MutableHandle<JS::Value>) [jsapi.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 2623 + 0x18]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfe160
09:21:50 INFO - rip = 0x00007fffb2fa5d1a
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 34 xul.dll!mozilla::dom::EventListener::HandleEvent(JSContext *,JS::Handle<JS::Value>,mozilla::dom::Event &,mozilla::ErrorResult &) [EventListenerBinding.cpp: : 52 + 0x12]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfe260
09:21:50 INFO - rip = 0x00007fffb25dd9a0
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 35 xul.dll!nsresult mozilla::EventListenerManager::HandleEventSubType(struct mozilla::EventListenerManager::Listener *, class mozilla::dom::Event *, class mozilla::dom::EventTarget *) [EventListenerManager.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 1038 + 0xf4]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfe3b0
09:21:50 INFO - rip = 0x00007fffb25dd5c2
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 36 xul.dll!void mozilla::EventTargetChainItem::HandleEvent(class mozilla::EventChainPostVisitor & const, class mozilla::ELMCreationDetector & const) [EventDispatcher.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 351 + 0x702]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfe5f0
09:21:50 INFO - rip = 0x00007fffb24906da
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 37 xul.dll!static void mozilla::EventTargetChainItem::HandleEventTargetChain(class nsTArray<mozilla::EventTargetChainItem> & const, class mozilla::EventChainPostVisitor & const, class mozilla::EventDispatchingCallback *, class mozilla::ELMCreationDetector & const) [EventDispatcher.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 553 + 0x10]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfe7e0
09:21:50 INFO - rip = 0x00007fffb248f63b
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 38 xul.dll!mozilla::EventDispatcher::Dispatch(nsISupports *,nsPresContext *,mozilla::WidgetEvent *,mozilla::dom::Event *,nsEventStatus *,mozilla::EventDispatchingCallback *,nsTArray<mozilla::dom::EventTarget *> *) [EventDispatcher.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 1044 + 0x25]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfe900
09:21:50 INFO - rip = 0x00007fffb248e177
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 39 xul.dll!mozilla::EventDispatcher::DispatchDOMEvent(nsISupports *,mozilla::WidgetEvent *,mozilla::dom::Event *,nsPresContext *,nsEventStatus *) [EventDispatcher.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 0 + 0x5]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfebd0
09:21:50 INFO - rip = 0x00007fffb248d329
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 40 xul.dll!nsINode::DispatchEvent(mozilla::dom::Event &,mozilla::dom::CallerType,mozilla::ErrorResult &) [nsINode.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 1028 + 0x15]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfec40
09:21:50 INFO - rip = 0x00007fffb25c2695
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 41 xul.dll!nsContentUtils::DispatchEvent(mozilla::dom::Document *,nsISupports *,nsTSubstring<char16_t> const &,mozilla::CanBubble,mozilla::Cancelable,mozilla::Composed,mozilla::Trusted,bool *,mozilla::ChromeOnlyDispatch) [nsContentUtils.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 4083 + 0x11]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfecd0
09:21:50 INFO - rip = 0x00007fffb25dc453
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 42 xul.dll!mozilla::dom::Document::DispatchContentLoadedEvents() [Document.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 4693 + 0x60]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfed60
09:21:50 INFO - rip = 0x00007fffb25db40b
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 43 xul.dll!nsresult mozilla::detail::RunnableMethodImpl<(anonymous namespace)::HangMonitorChild ,void ((anonymous namespace)::HangMonitorChild::)(),0,mozilla::RunnableKind::Standard>::Run() [nsThreadUtils.h:68a001a424062bc60dd8ed56ae263162f1d56d6c : 1171 + 0xa]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfee70
09:21:50 INFO - rip = 0x00007fffb3c1dd9a
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 44 xul.dll!nsresult mozilla::SchedulerGroup::Runnable::Run() [SchedulerGroup.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 292 + 0x6]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfeea0
09:21:50 INFO - rip = 0x00007fffb3c6163f
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 45 xul.dll!nsThread::ProcessNextEvent(bool,bool *) [nsThread.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 1162 + 0xb]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dfeee0
09:21:50 INFO - rip = 0x00007fffb23bd095
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 46 xul.dll!NS_ProcessNextEvent(nsIThread *,bool) [nsThreadUtils.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 474 + 0xd]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dff410
09:21:50 INFO - rip = 0x00007fffb23bcab9
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 47 xul.dll!void mozilla::ipc::MessagePump::Run(class base::MessagePump::Delegate *) [MessagePump.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 88 + 0xa]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dff460
09:21:50 INFO - rip = 0x00007fffb25a08ab
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 48 xul.dll!MessageLoop::RunHandler() [message_loop.cc:68a001a424062bc60dd8ed56ae263162f1d56d6c : 308 + 0xf]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dff4d0
09:21:50 INFO - rip = 0x00007fffb2395578
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 49 xul.dll!MessageLoop::Run() [message_loop.cc:68a001a424062bc60dd8ed56ae263162f1d56d6c : 290 + 0x5]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dff520
09:21:50 INFO - rip = 0x00007fffb23bc751
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 50 xul.dll!nsBaseAppShell::Run() [nsBaseAppShell.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 137 + 0xd]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dff570
09:21:50 INFO - rip = 0x00007fffb25a0788
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 51 xul.dll!nsAppShell::Run() [nsAppShell.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 411 + 0x8]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dff5b0
09:21:50 INFO - rip = 0x00007fffb25a0063
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 52 xul.dll!XRE_RunAppShell() [nsEmbedFunctions.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 908 + 0x6]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dff5e0
09:21:50 INFO - rip = 0x00007fffb6c1f2a5
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 53 xul.dll!MessageLoop::RunHandler() [message_loop.cc:68a001a424062bc60dd8ed56ae263162f1d56d6c : 308 + 0xf]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dff620
09:21:50 INFO - rip = 0x00007fffb2395578
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 54 xul.dll!MessageLoop::Run() [message_loop.cc:68a001a424062bc60dd8ed56ae263162f1d56d6c : 290 + 0x5]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dff670
09:21:50 INFO - rip = 0x00007fffb23bc751
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 55 xul.dll!XRE_InitChildProcess(int,char * * const,XREChildData const *) [nsEmbedFunctions.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 746 + 0x5]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dff6c0
09:21:50 INFO - rip = 0x00007fffb6c1eee2
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 56 firefox.exe!static int content_process_main(class mozilla::Bootstrap *, int, char * *) [plugin-container.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 49 + 0x13]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dff900
09:21:50 INFO - rip = 0x00007ff7017114e5
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 57 firefox.exe!static int NS_internal_main(int, char * *, char * *) [nsBrowserApp.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 265 + 0xa]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dff960
09:21:50 INFO - rip = 0x00007ff70171143b
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 58 firefox.exe!wmain [nsWindowsWMain.cpp:68a001a424062bc60dd8ed56ae263162f1d56d6c : 129 + 0x15]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dff9e0
09:21:50 INFO - rip = 0x00007ff70171111e
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 59 firefox.exe!static int __scrt_common_main_seh() [exe_common.inl : 288 + 0x22]
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dffa40
09:21:50 INFO - rip = 0x00007ff701754808
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 60 kernel32.dll!BaseThreadInitThunk + 0x14
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dffa80
09:21:50 INFO - rip = 0x00007ffff84f3034
09:21:50 INFO - Found by: call frame info
09:21:50 INFO - 61 ntdll.dll!SdbpCheckMatchingFiles + 0x81
09:21:50 INFO - rbp = 0x000001ede455e800 rsp = 0x0000002ad6dffab0
09:21:50 INFO - rip = 0x00007ffffa831461
09:21:50 INFO - Found by: call frame info
09:21:50 INFO -

Flags: needinfo?(kmaglione+bmo)

Kris Maglione [:kmag]

Assignee

Updated

•

5 years ago

Flags: needinfo?(kmaglione+bmo)

Keywords: leave-open

Kris Maglione [:kmag]

Assignee

Comment 18

•

5 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9744b9a4d03b238187c975f54745462bac0c1a3
Bug 1524687 - Part 0: Fix more dodgy component mocking code. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/a32ebe2b0f5c5d1c34c8183738b60d20cbc16d1a
Bug 1524687: Part 1 - Convert PaymentRequestModule to static manifest. r=edenchuang

https://hg.mozilla.org/integration/mozilla-inbound/rev/0604276bb96d42ab5db3119c315c4437400e2da9
Bug 1524687: Part 2 - Convert most of the embedding module to static registration. r=mossop

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d57013b19ade13f29bbb2c088a993fc5d3f4f04
Bug 1524687: Part 3 - Convert nsImageModule to static registration. r=jwatt

https://hg.mozilla.org/integration/mozilla-inbound/rev/79b2023271fab29fa7921d9cd1adf05dca33700e
Bug 1524687: Part 4 - Convert Places module to static registration. r=mak

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a36f7e03c9598598014121ac5b13f1e3becb91b
Bug 1524687: Part 5 - Convert JAR module to static registration. r=valentin

https://hg.mozilla.org/integration/mozilla-inbound/rev/d01128577300990f8a05c422790e944326d71a6a
Bug 1524687: Part 6 - Convert intl modules to static registration. r=zbraniecki

https://hg.mozilla.org/integration/mozilla-inbound/rev/2adca0b87821aa2db9e6891cf493f9bcf07f2373
Bug 1524687: Part 7 - Convert media bridge module to static registration. r=jesup

https://hg.mozilla.org/integration/mozilla-inbound/rev/b663c11ca61f033bd52e1fc8488693a2da6feeab
Bug 1524687: Part 8 - Convert remaining toolkit modules to static registration. r=mossop

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c6224158f64ae4291133faa56f538413092ff98
Bug 1524687: Part 9 - Convert gtk widget module to static registration. r=erahm

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a18627596250d711ad705f67b14b21a97b2542e
Bug 1524687: Part 11 - Convert browser modules to static registration. r=mossop

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8ad5619116c31fc4d38e0e789ddb9b5d2a5bb25
Bug 1524687: Part 12 - Convert everything else to static registration. r=erahm

Kris Maglione [:kmag]

Assignee

Comment 19

•

5 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c3aeedfe69d8f743eef876afc98ac3c013f43d5
Backout most of bug 1524687 for Windows PGO xpcshell selftest failures. r=backout

Kris Maglione [:kmag]

Assignee

Comment 20

•

5 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/7436c0f5b8b1583d20d5ea2d1d9d3b2c665bdf33
Fix botched backout (bug 1524687). r=bustage

Kris Maglione [:kmag]

Assignee

Updated

•

5 years ago

Keywords: leave-open

Kris Maglione [:kmag]

Assignee

Comment 21

•

5 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/86cf09db340b5bfebb8e9bb66d6068e20f10cf8c
Bug 1524687: Part 4 - Convert Places module to static registration. r=mak

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb33f7e6467c1273fdd8fba7c45b9e715ba12850
Bug 1524687: Part 8 - Convert remaining toolkit modules to static registration. r=mossop

https://hg.mozilla.org/integration/mozilla-inbound/rev/accad7b4cbc71f35ffd4912044aa82c45872bb94
Bug 1524687: Part 10 - Convert Windows widget module to static registration. r=erahm

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a1ef487a9e74d66b112034051e49b77023860b8
Bug 1524687: Part 12 - Convert everything else to static registration. r=erahm

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f06a6b51bfe6dd8adbc3c2bd6deae3cdc3a2061
Bug 1524687: Follow-up: Add temporary dummy modules to work around Win PGO bustage. r=me

Arthur Iakab [arthur_iakab]

Comment 22

•

5 years ago

•

Edited

Backed out 5 changesets (bug 1524687) for causing build bustages on platform.h CLOSED TREE

Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/f7b7baadf1a1f3f4eb0543c1aa4b231c32aae70a

Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&revision=0f06a6b51bfe6dd8adbc3c2bd6deae3cdc3a2061

Failure logs https://treeherder.mozilla.org/logviewer.html#?job_id=229495105&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=229495116&repo=mozilla-inbound

:kmag could you please take a look?

Flags: needinfo?(kmaglione+bmo)

Kris Maglione [:kmag]

Assignee

Comment 23

•

5 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/98ab5a6bf219e2959fdff38db2cabe4154206977
Bug 1524687: Part 4 - Convert Places module to static registration. r=mak

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3a0e6aced8e442091e4167199310de44689d45b
Bug 1524687: Part 8 - Convert remaining toolkit modules to static registration. r=mossop

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa110fb783d526a0aa742b5fa5472d9bdfc1ca8c
Bug 1524687: Part 10 - Convert Windows widget module to static registration. r=erahm

https://hg.mozilla.org/integration/mozilla-inbound/rev/860bdc8fa78af1c8a20cbbcd41b29341369723c1
Bug 1524687: Part 12 - Convert everything else to static registration. r=erahm

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f364df33809aa47a1b97c31b0093ba082c5b775
Bug 1524687: Follow-up: Add temporary dummy modules to work around Win PGO bustage. r=me

Oana Pop-Rus

Comment 24

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/98ab5a6bf219
https://hg.mozilla.org/mozilla-central/rev/c3a0e6aced8e
https://hg.mozilla.org/mozilla-central/rev/aa110fb783d5
https://hg.mozilla.org/mozilla-central/rev/860bdc8fa78a
https://hg.mozilla.org/mozilla-central/rev/5f364df33809

Status: NEW → RESOLVED

Closed: 5 years ago

status-firefox67: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla67

Jorg K (CEST = GMT+2)

Comment 25

•

5 years ago

Drive-by comment: This looks really strange, why is it added again?

https://hg.mozilla.org/mozilla-central/rev/c3a0e6aced8e#l2.12
https://hg.mozilla.org/mozilla-central/rev/c3a0e6aced8e#l3.12

https://hg.mozilla.org/mozilla-central/rev/98ab5a6bf219#l1.12
This changeset doesn't reflect https://phabricator.services.mozilla.com/D18399

Kris Maglione [:kmag]

Assignee

Comment 26

•

5 years ago

Bah. I'm surprised graft didn't treat those as conflicts...

Flags: needinfo?(kmaglione+bmo)

Kris Maglione [:kmag]

Assignee

Comment 27

•

5 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/9126918c9977bed98524bccb703391f05146db38
Bug 1524687: Follow-up: Fix rebase artifacts. r=trivial DONTBUILD

Raul Gurzau (:RaulG)

Comment 28

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/9126918c9977

Mike Hommey [:glandium]

Updated

•

5 years ago

Regressions: 1575415

You need to log in before you can comment on or make changes to this bug.