File picker shown instead of Application chooser when choosing what to do with a downloaded file
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
People
(Reporter: glandium, Assigned: glandium)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
jcristau
:
approval-mozilla-esr68+
|
Details | Review |
Bug 1524687 broke the component registration for the application chooser on Gtk builds, so that it's never used, and we instead get the file chooser. That's a UX regression (choosing an executable via a file picker to use as an application to open a downloaded file is dreadful compare to choosing an application)
STR:
- Open a link that downloads a file. e.g. https://ftp.mozilla.org/pub/firefox/releases/68.0.2/linux-x86_64/en-US/firefox-68.0.2.tar.bz2
- In the dialog that opens, under "What should Firefox do with this file?", next to "open with", open the drop-down and choose "Other..."
Actual result:
- A "Choose Helper Application" dialog that looks a lot like "Open File".
Expected result:
- A "Choose Helper Application" dialog that only contains a list of applications to pick from.
Bug 1524687 landed in 67, so this affects 67, 68 and 69 as of now.
Assignee | ||
Comment 1•5 years ago
|
||
Bug 1278282 removed Gtk2 support, so MOZ_WIDGET_TOOLKIT is always "gtk3"
for Gtk builds, and never "gtk", which makes the current check never
match.
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Comment on attachment 9086873 [details]
Bug 1575415 - Always register the nsApplicationChooser component in Gtk builds.
Beta/Release Uplift Approval Request
- User impact if declined: UX regression for something that was there since Firefox 59.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See STR in comment 0
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This only re-enables a component that was present since Firefox 59 and hasn't changed since, but was disabled due to a typo.
- String changes made/needed: N/A
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 4•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Confirmed issue with 69.0b7.
Verified fix with 70.0a1 (2019-08-22) on Ubuntu 16.0.4.
Comment 6•5 years ago
|
||
Comment on attachment 9086873 [details]
Bug 1575415 - Always register the nsApplicationChooser component in Gtk builds.
approved for 68.1esr and the last 69 beta
Comment 7•5 years ago
|
||
bugherder uplift |
Comment 8•5 years ago
|
||
bugherder uplift |
Comment 9•5 years ago
•
|
||
Verified with 69.0b16 and esr68.1.0 from taskCluster on Ubuntu 18.04.
Comment 10•5 years ago
|
||
Updating flag for beta as well.
Updated•5 years ago
|
Updated•3 years ago
|
Description
•