1575415 - File picker shown instead of Application chooser when choosing what to do with a downloaded file

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Mike Hommey [:glandium]]

Bug 1524687 broke the component registration for the application chooser on Gtk builds, so that it's never used, and we instead get the file chooser. That's a UX regression (choosing an executable via a file picker to use as an application to open a downloaded file is dreadful compare to choosing an application)

STR:

• Open a link that downloads a file. e.g. https://ftp.mozilla.org/pub/firefox/releases/68.0.2/linux-x86_64/en-US/firefox-68.0.2.tar.bz2
• In the dialog that opens, under "What should Firefox do with this file?", next to "open with", open the drop-down and choose "Other..."

Actual result:

• A "Choose Helper Application" dialog that looks a lot like "Open File".

Expected result:

• A "Choose Helper Application" dialog that only contains a list of applications to pick from.

Bug 1524687 landed in 67, so this affects 67, 68 and 69 as of now.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1575415 - Always register the nsApplicationChooser component in Gtk builds.

Bug 1278282 removed Gtk2 support, so MOZ_WIDGET_TOOLKIT is always "gtk3"
for Gtk builds, and never "gtk", which makes the current check never
match.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b29e32f7290
Always register the nsApplicationChooser component in Gtk builds. r=froydnj

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 9086873 [details]
Bug 1575415 - Always register the nsApplicationChooser component in Gtk builds.

Beta/Release Uplift Approval Request

• User impact if declined: UX regression for something that was there since Firefox 59.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See STR in comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only re-enables a component that was present since Firefox 59 and hasn't changed since, but was disabled due to a typo.
• String changes made/needed: N/A

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/4b29e32f7290

Comment 5

[Cristian Fogel [:cfogel]]

Confirmed issue with 69.0b7.
Verified fix with 70.0a1 (2019-08-22) on Ubuntu 16.0.4.

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9086873 [details]
Bug 1575415 - Always register the nsApplicationChooser component in Gtk builds.

approved for 68.1esr and the last 69 beta

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/8e5270f2247b

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2be563909f58

Comment 9

[Cristian Fogel [:cfogel]]

Verified with 69.0b16 and esr68.1.0 from taskCluster on Ubuntu 18.04.

Comment 10

[Cristian Fogel [:cfogel]]

Updating flag for beta as well.