1524908 - One off search buttons are broken after customize (duplicate rows)

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[atlanto]

Attachment: (screenshot)

STR:

1. Start nightly with new profile
2. Enter customize mode (right-click on tab-bar, click "Customize")
3. Chenge theme and exit customize mode
4. Type something in address-bar

AR:
Search engine icons are displayed twice or more.(see screenshot)

mozregression result:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9658187a54fbd9e7c5bda51fb4e5a041a7af77be&tochange=add76bbdce4e452d1f921bcbc1224b30892d8393

Comment 1

[atlanto]

Attachment: (screenshot)

Another STR:

1. Start nightly with new profile
2. Remove flexible-spaces around address-bar
3. Type something in address-bar

AR:
(see screenshot)

Comment 2

[Sylvestre Ledru [:Sylvestre]]

[Tracking Requested - why for this release]: Obvious visual regression

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1524908 - Since the Search Service API is now asynchronous, the one-off-search (re)build method became re-entrant and evidently race-y. Let's guard against that. r?dao!

Comment 5

[Mike de Boer [:mikedeboer]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e21b66cc60f767025ed4b9ae384be0271dcbc37f

Comment 6

[Mike de Boer [:mikedeboer]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f509f0f248ee0e6aad3140f106154266aa9b721

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a5768488340
Since the Search Service API is now asynchronous, the one-off-search (re)build method became re-entrant and evidently race-y. Let's guard against that. r=dao

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 0a5768488340 (Bug 1524908) for bc failures at browser_urlbar_keyed_search.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/d9a8154ffc313522ab0d641cd17b17033d212e76

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=0a5768488340fbc92616e7b646c3c89a64a415e0&selectedJob=226462680

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=226462680&repo=autoland&lineNumber=1799

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a72cce99f449
Since the Search Service API is now asynchronous, the one-off-search (re)build method became re-entrant and evidently race-y. Let's guard against that. r=dao

Comment 10

[Mike de Boer [:mikedeboer]]

Fixed test and relanded.

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a72cce99f449

Comment 12

[Md Maruf Rahman]

I have reproduced this bug with Nightly 67.0a1 (2019-02-03) on Windows 10, 64 Bit. The fix of this bug is verified with latest Nightly 67.0a1!

Build ID : 20190211215545
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Comment 13

[Oana Botisan, Desktop QA]

I will mark this bug as Verified Fixed as per comment 12.