Closed Bug 1524967 Opened 10 months ago Closed 10 months ago

[BinAST] js/src/frontend/binsource/src/main.rs never skips overwriting the file due to auto format

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1473202 added a code path that skips overwriting the auto-generated file for BinAST when there's no change.
Now we use clang-format after that phase, and the content always differ, and it never skips.
We should move the "skip" part after the format, or just remove that logic.

Summary: js/src/frontend/binsource/src/main.rs never skips overwriting the file due to auto format → [BinAST] js/src/frontend/binsource/src/main.rs never skips overwriting the file due to auto format
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Priority: P5 → P3
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/5ddf9d49a6b3
Check if BinAST auto-generated source is update in build.sh. r=Yoric
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Depends on: 1530389
You need to log in before you can comment on or make changes to this bug.