1530389 - Bustages at build/src/js/src/frontend/Parser.h when Gecko 67 merges to beta on 2019-03-11

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Oana Pop-Rus]

[Tracking Requested - why for this release]:

Central as beta: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=2c63be46977469b2388384a8301fe064e2eb5236&selectedJob=230286023

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=230286023&repo=try&lineNumber=5394

[task 2019-02-25T12:40:18.387Z] 12:40:18 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/config/external/icu/common'
[task 2019-02-25T12:40:18.523Z] 12:40:18 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src'
[task 2019-02-25T12:40:18.524Z] 12:40:18 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -m32 -o RegExp.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DJS_HAS_CTYPES -DFFI_BUILDING -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-firefox/js/src -I/builds/worker/workspace/build/src/obj-firefox/js/src/ctypes/libffi/include -I/builds/worker/workspace/build/src/js/src/ctypes/libffi/src/x86 -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/js/src/js-confdefs.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-noexcept-type -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -MD -MP -MF .deps/RegExp.o.pp /builds/worker/workspace/build/src/js/src/builtin/RegExp.cpp
[task 2019-02-25T12:40:18.526Z] 12:40:18 INFO - In file included from /builds/worker/workspace/build/src/js/src/builtin/RegExp.cpp:22:
[task 2019-02-25T12:40:18.528Z] 12:40:18 INFO - In file included from /builds/worker/workspace/build/src/js/src/vm/EnvironmentObject-inl.h:10:
[task 2019-02-25T12:40:18.528Z] 12:40:18 INFO - In file included from /builds/worker/workspace/build/src/js/src/vm/EnvironmentObject.h:10:
[task 2019-02-25T12:40:18.528Z] 12:40:18 INFO - In file included from /builds/worker/workspace/build/src/js/src/builtin/ModuleObject.h:15:
[task 2019-02-25T12:40:18.528Z] 12:40:18 INFO - In file included from /builds/worker/workspace/build/src/js/src/frontend/EitherParser.h:24:
[task 2019-02-25T12:40:18.528Z] 12:40:18 INFO - In file included from /builds/worker/workspace/build/src/js/src/frontend/BCEParserHandle.h:12:
[task 2019-02-25T12:40:18.528Z] 12:40:18 ERROR - /builds/worker/workspace/build/src/js/src/frontend/Parser.h:272:29: error: no function named 'TraceBinParser' with type 'void (JSTracer *, JS::AutoGCRooter )' was found in the specified scope
[task 2019-02-25T12:40:18.529Z] 12:40:18 INFO - friend void js::frontend::TraceBinParser(JSTracer trc,
[task 2019-02-25T12:40:18.529Z] 12:40:18 INFO - ^
[task 2019-02-25T12:40:18.529Z] 12:40:18 INFO - 1 error generated.
[task 2019-02-25T12:40:18.529Z] 12:40:18 INFO - /builds/worker/workspace/build/src/config/rules.mk:805: recipe for target 'RegExp.o' failed
[task 2019-02-25T12:40:18.529Z] 12:40:18 ERROR - make[4]: *** [RegExp.o] Error 1
[task 2019-02-25T12:40:18.529Z] 12:40:18 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src'
[task 2019-02-25T12:40:18.529Z] 12:40:18 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'js/src/target' failed
[task 2019-02-25T12:40:18.529Z] 12:40:18 ERROR - make[3]: *** [js/src/target] Error 2
[task 2019-02-25T12:40:18.529Z] 12:40:18 INFO - make[3]: *** Waiting for unfinished jobs....
[task 2019-02-25T12:40:18.529Z] 12:40:18 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/config/external/icu/common'
[task 2019-02-25T12:40:18.529Z] 12:40:18 INFO - config/external/icu/common/edits.o
[task 2019-02-25T12:40:18.529Z] 12:40:18 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/config/external/icu/common'
[task 2019-02-25T12:40:18.553Z] 12:40:18 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/modules/fdlibm/src'
[task 2019-02-25T12:40:18.555Z] 12:40:18 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -m32 -o s_nearbyint.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/modules/fdlibm/src -I/builds/worker/workspace/build/src/obj-firefox/modules/fdlibm/src -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -Wno-parentheses -Wno-sign-compare -Wno-dangling-else -MD -MP -MF .deps/s_nearbyint.o.pp /builds/worker/workspace/build/src/modules/fdlibm/src/s_nearbyint.cpp
[task 2019-02-25T12:40:18.556Z] 12:40:18 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/modules/fdlibm/src'
[task 2019-02-25T12:40:18.557Z] 12:40:18 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/modules/fdlibm/src'
[task 2019-02-25T12:40:18.557Z] 12:40:18 INFO - modules/fdlibm/src/s_rint.o

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1530389 - Enclose BinAST code in Parser.h with JS_BUILD_BINAST. r?Yoric

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e5a341f5662
Enclose BinAST code in Parser.h with JS_BUILD_BINAST. r=Yoric

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7e5a341f5662

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with latest beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=d696592f565abb5545d14667ff252a95a4c23590