Copying a search suggestion from QuantumBar can copy a bad URL instead of the suggestion

RESOLVED FIXED in Firefox 67

Status

()

defect
P3
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: standard8, Assigned: dao)

Tracking

(Blocks 2 bugs)

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

Reporter

Description

5 months ago

STR

  1. Enter for in the address bar
  2. Look for a one-word search suggestion, e.g. fortnite
  3. Arrow-down to that word
  4. Do select-all, e.g. cmd-A
  5. Paste the result somewhere else.

Expected Results

=> fortnite

Actual Results

=> http://fortnite

Our copy function is missing the piece of code to check for a search suggestion:

https://searchfox.org/mozilla-central/rev/60c4067b1cbb0f94d7dc2d7cdfa27ed579817fee/browser/base/content/urlbarBindings.xml#1100-1103

This also makes part of browser_urlbarSearchSuggestions.js fail.

Assignee

Updated

4 months ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED

Comment 2

4 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/502cc11396ce
Handle copying autocompleted non-URL values. r=Standard8

Comment 3

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.