Closed Bug 1525018 Opened 6 years ago Closed 6 years ago

Copying a search suggestion from QuantumBar can copy a bad URL instead of the suggestion

Categories

(Firefox :: Address Bar, defect, P3)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: standard8, Assigned: dao)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1525018 - Handle copying autocompleted non-URL values. r=Standard8
47 bytes, text/x-phabricator-request
Details | Review

STR

  1. Enter for in the address bar
  2. Look for a one-word search suggestion, e.g. fortnite
  3. Arrow-down to that word
  4. Do select-all, e.g. cmd-A
  5. Paste the result somewhere else.

Expected Results

=> fortnite

Actual Results

=> http://fortnite

Our copy function is missing the piece of code to check for a search suggestion:

https://searchfox.org/mozilla-central/rev/60c4067b1cbb0f94d7dc2d7cdfa27ed579817fee/browser/base/content/urlbarBindings.xml#1100-1103

This also makes part of browser_urlbarSearchSuggestions.js fail.

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/502cc11396ce Handle copying autocompleted non-URL values. r=Standard8

https://hg.mozilla.org/mozilla-central/rev/502cc11396ce

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Regressions: 1573753
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: