1522489 - [meta] Port remaining urlbar tests to QuantumBar

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Mark Banner (:standard8)]

We should port the remaining Urlbar tests to QuantumBar where possible. The tests concerned are those in browser/components/urlbar/tests/legacy/.

Some of those may require functionality not present yet - so we'll need to ensure we have bugs for those.

This depends on bug 1520494 as in that bug we're adding some extra functionality to UrlbarTestUtils to handle both the legacy bar and QuantumBar.

We should also consider adding extra helper methods if necessary to hide the implementation of the input/view, e.g. for checking result lists or entries.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1522489 - Rename some urlbar tests to better inform what they are testing. r?mak

Comment 2

[Phabricator Automation]

Comment on attachment 9039744 [details]
Bug 1522489 - Rename some urlbar tests to better inform what they are testing. r?mak

Revision D17927 was moved to bug 1523356. Setting attachment 9039744 [details] to obsolete.

Comment 3

[Mark Banner (:standard8)]

Just going to convert this to a meta... I think it makes sense.

Comment 4

[Mark Banner (:standard8)]

This is now fixed. Tests that were disabled after porting due to not fully working have their own bugs filed against quantumbar-tests.

The few remaining tests in the legacy/ directory won't be ported as they aren't relevant to QuantumBar.