Closed Bug 1522489 Opened 2 years ago Closed 2 years ago

[meta] Port remaining urlbar tests to QuantumBar

Categories

(Firefox :: Address Bar, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: meta, Whiteboard: [fxsearch])

Attachments

(1 obsolete file)

We should port the remaining Urlbar tests to QuantumBar where possible. The tests concerned are those in browser/components/urlbar/tests/legacy/.

Some of those may require functionality not present yet - so we'll need to ensure we have bugs for those.

This depends on bug 1520494 as in that bug we're adding some extra functionality to UrlbarTestUtils to handle both the legacy bar and QuantumBar.

We should also consider adding extra helper methods if necessary to hide the implementation of the input/view, e.g. for checking result lists or entries.

Blocks: 1522440
Blocks: 1522438
Blocks: 1522495
Blocks: 1522504
Blocks: 1522508
Blocks: 1522512
Blocks: 1522514
Blocks: 1522516
Blocks: 1522521
Blocks: 1522530
Depends on: 1523356

Comment on attachment 9039744 [details]
Bug 1522489 - Rename some urlbar tests to better inform what they are testing. r?mak

Revision D17927 was moved to bug 1523356. Setting attachment 9039744 [details] to obsolete.

Attachment #9039744 - Attachment is obsolete: true
Depends on: 1524218
Depends on: 1524377
Depends on: 1524536

Just going to convert this to a meta... I think it makes sense.

No longer depends on: 1524377
Keywords: meta
Summary: Port remaining urlbar tests to QuantumBar → [meta] Port remaining urlbar tests to QuantumBar
Depends on: 1524950
Depends on: 1525018
Depends on: 1525048
Depends on: 1525429
Depends on: 1525439
Depends on: 1526228
Depends on: 1526815
Depends on: 1527940
Blocks: 1530334
Depends on: 1531347

This is now fixed. Tests that were disabled after porting due to not fully working have their own bugs filed against quantumbar-tests.

The few remaining tests in the legacy/ directory won't be ported as they aren't relevant to QuantumBar.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.