1525035 - Verify and fix IME composition

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P3)

Description

[Marco Bonardo [:mak]]

The old autocomplete controller handles a bunch of IME composition events, adn we apparently don't have anything for that yet. For example see
https://searchfox.org/mozilla-central/rev/152993fa346c8fd9296e4cd6622234a664f53341/toolkit/components/autocomplete/nsAutoCompleteController.cpp#178
https://searchfox.org/mozilla-central/rev/152993fa346c8fd9296e4cd6622234a664f53341/toolkit/components/autocomplete/nsAutoCompleteController.cpp#343
https://searchfox.org/mozilla-central/rev/152993fa346c8fd9296e4cd6622234a664f53341/toolkit/components/autocomplete/nsAutoCompleteController.cpp#372

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Yeah, currently, we stop suggesting anything while user types something via IME because IME may show their own popup window to show suggesting words (like autocomplete) and/or candidate list of conversion under or over our popup window. In other words, if new UI didn't use popup, it wouldn't need to stop working even while IME composition.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1525035 - Handle IME composition in Quantum Bar. r=adw!

Comment 3

[Marco Bonardo [:mak]]

I filed bug 1529927 to port some of the autocomplete binding tests to the urlbar, some of those also cover IME.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62bec7b76cab
Handle IME composition in Quantum Bar. r=adw

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/62bec7b76cab

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/62bec7b76cab