1947268 - See if we still need composition event handling in urlbar.

Status: NEW

(Firefox :: Address Bar, task, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

This was brought up in #fx-desktop-dev. This was added in bug 1525035.

My understanding is that it could be annoying if the popup overlapped native IME UI. But now we no longer use a native popup for the urlbar so it seems we should be able to just get rid of that code. Am I missing something?

Comment 1

[Emilio Cobos Álvarez [:emilio]]

:Standard8 mentioned that bug 1685991 and the relevant pref is also related. But that said... Not searching makes sense to me, but closing the view seems it'd be always useless now?

Comment 2

[Mauro B]

I was taking a look at the functionality. As you said, the urlbar used to be a panel where as it isn't now. The comment for the preference states that: "The default value is false because some IME open a picker panel, and we end up with two panels on top of each other". So again, this woudn't make sense anymore as it isn't a panel anymore?

I'd personally enable the flag on nightly and see if it affects any users, but I doubt.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Sorry, I don't get what did you mean. When typing something, the URL bar shows a suggest list, which may be overlapped with some UI of IME. I don't know what's happened about the our panel, however, anyway there are popup like UI at least. The popup like UI could make some users complain about overlapping with IME UI which we cannot control the position.

Comment 4

[Marco Bonardo [:mak]]

I think the original concern was not urlbar panel covering ime, but ime covering urlbar panel and generating a potentially confusing and noisy ui situation.
Even if we don't close the panel, we'd still need composition events to avoid searching for partial strings.
And we already have an option to not close the panel the user can enable (we'll move it from Labs to Search) that works well with certain IME (korean, vietnamese underlined, ...).

So, I think this request means:

1. make the option default to true
2. during composition don't start searches, so results are frozen to the previous ones

That would still leave us with a potentially confusing state with ime popup on top of urlbar panel containing outdated results.

Comment 5

[Marco Bonardo [:mak]]

Emilio, could you please check our replies and let us know if there's still something you think it would be worth investigating?

Comment 6

[Emilio Cobos Álvarez [:emilio]]

I think the original concern was not urlbar panel covering ime, but ime covering urlbar panel and generating a potentially confusing and noisy ui situation.

Hmm, isn't that how the UI would be with any other panel-like behavior (e.g., the gmail search interface or what not)? I don't think that's necessarily confusing...

Even if we don't close the panel, we'd still need composition events to avoid searching for partial strings. [...]
So, I think this request means:

1. make the option default to true
2. during composition don't start searches, so results are frozen to the previous ones

I would've expected this to be the behavior (the UI remains the same, we just don't search while composing). So yeah, I think that's basically the request :)

That would still leave us with a potentially confusing state with ime popup on top of urlbar panel containing outdated results.

Same comment about not thinking this is really confusing, but I'm not an avid IME user, so happy to let other people take this call.

Comment 7

[James Teow [:jteow]]

We should investigate if we can keep the panel open.