1525185 - [about:addons] Confirm that all the telemetry is still there

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Description

[Mark Striemer [:mstriemer]]

Telemetry should be added to views as they're converted, but we should audit what has been setup to confirm that nothing was removed.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1525185 - Telemetry for HTML about:addons r?rpl

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a02341b39691
Telemetry for HTML about:addons r=mixedpuppy,rpl

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a02341b39691

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 5

[Rob Wu [:robwu]]

This targets 68 (and needs to be uplifted).

Comment 6

[Mark Striemer [:mstriemer]]

Comment on attachment 9065885 [details]
Bug 1525185 - Telemetry for HTML about:addons r?rpl

Beta/Release Uplift Approval Request

• User impact if declined: Telemetry will be missing from some HTML about:addons actions.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: bug 1557944
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This uses the existing helper methods from the XUL about:addons to record telemetry for the HTML version. These helpers cannot throw.
• String changes made/needed: No

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9065885 [details]
Bug 1525185 - Telemetry for HTML about:addons r?rpl

approved for 68.0b10

Comment 8

[Narcis Beleuzu [:NarcisB]]

There are conflicts while merging to beta.
toolkit/mozapps/extensions/content/aboutaddons.js

:mstriemer , can you please take a look?

Comment 9

[Rob Wu [:robwu]]

This patch depends on changes from bug 1550911.

According to the last relman comment on that bug, that patch will be uplifted when some translations are ready.

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d5aba1791f11