RESOLVED FIXED in Firefox 67

Status

()

defect
P3
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: glandium, Assigned: myk)

Tracking

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Reporter

Comment 1

5 months ago

Myk, would you mind taking this?

Flags: needinfo?(myk)
Assignee

Comment 2

4 months ago

(In reply to Mike Hommey [:glandium] from comment #1)

Myk, would you mind taking this?

Yep, I've cherry-picked it to this branch in mozilla/lmdb/:

https://github.com/mozilla/lmdb/tree/mdb.RE/0.9.21-moz

And I've created this branch in mozilla/lmdb-rs that uses that branch of mozilla/lmdb:

https://github.com/mozilla/lmdb-rs/tree/lmdb-sys-0.8.0-android-fix

I've also updated the patch in bug 1490496 to use that branch as its source for the lmdb-sys crate:

https://phabricator.services.mozilla.com/D6328#change-rFeP59HZ8M0a

That should resolve the Android build issue for that patch. But it's just a temporary workaround. In the long term, we should update the version of rkv (and thus LMDB) that is vendored into the tree, which is now several versions newer than the one in that patch. I filed bug 1525392 to do that.

Assignee: nobody → myk
Status: NEW → ASSIGNED
Flags: needinfo?(myk)

Giving this a priority to get it out of the triage list - please change as necessary.

Priority: -- → P3
Assignee

Comment 4

4 months ago

The fix for build bug 1512541 causes an Android build issue. The issue has been fixed upstream in LMDB's development branch, but the fix hasn't made it to LMDB's release branch. So I backported it to a branch in the mozilla/lmdb-rs repo, and this change switches to that branch to fix the Android build issue.

Comment 6

4 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/cc0ffcd544f0
use version of lmdb-sys with fix for Android build issue r=glandium,froydnj

Comment 7

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.