Closed Bug 1525245 Opened 2 years ago Closed 2 years ago

Don't apply cookie policy and cookie permission changes to live documents

Categories

(Core :: DOM: Security, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: baku, Assigned: baku)

References

(Depends on 1 open bug)

Details

(Whiteboard: [domsecurity-backlog1] [domsecurity-active])

Attachments

(17 files, 2 obsolete files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-backlog1] [domsecurity-active]
Attachment #9042075 - Attachment is obsolete: true
Blocks: 1526075
Attachment #9042069 - Attachment description: Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 5 - BroadcastChannel, r?ehsan → Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 5 - BroadcastChannel must be blocked when cookie jar access is denied to avoid communication between live and new documents, r?ehsan
Attachment #9042070 - Attachment description: Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 6 - SharedWorker, r?ehsan → Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 6 - Tests for SharedWorker and cookie settings changing, r?ehsan
Attachment #9042071 - Attachment description: Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 7 - IndexedDB, r?ehsan → Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 7 - Tests for IndexedDB and cookie settings changing, r?ehsan
Attachment #9042072 - Attachment description: Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 8 - ServiceWorkers, r?ehsan → Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 8 - Tests for ServiceWorkers and cookie settings changing, r?ehsan
Attachment #9042073 - Attachment description: Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 9 - DOM Cache, r?ehsan → Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 9 - Tests for DOM Cache and cookie settings changing, r?ehsan
Attachment #9042076 - Attachment description: Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - windows/workers/documents, r?ehsan → Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - windows/workers/documents must keep the current cookie settings and ignore changes, r?ehsan

Andrea, did you note that your patches for bug 1526214 got mixed into the stack for this bug on Phabricator?

Flags: needinfo?(amarchesini)
Blocks: 1516540

Andrea, did you note that your patches for bug 1526214 got mixed into the stack for this bug on Phabricator?

Yes, I built them on top of the others. I'll rebase them all.

Flags: needinfo?(amarchesini)
Attachment #9042076 - Attachment description: Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 12 - windows/workers/documents must keep the current cookie settings and ignore changes, r?ehsan → Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 11 - windows/workers/documents must keep the current cookie settings and ignore changes, r?ehsan
Attachment #9043859 - Attachment description: Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 0 - nsPermissionManager::GetAllWithType, r?ehsan → Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 0 - nsPermissionManager::GetAllWithType, r?nika
Attachment #9043859 - Attachment is obsolete: true
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28147c8790d3
Stabilize cookiePolicy/cookiePermission for live documents - part 1 - information stored into loadInfo, r=Ehsan,ckerschb
https://hg.mozilla.org/integration/autoland/rev/d65fb2d2a243
Stabilize cookiePolicy/cookiePermission for live documents - part 2 - AntiTracking, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/1c359cdcf69f
Stabilize cookiePolicy/cookiePermission for live documents - part 3 - LocalStorage and SessionStorage, r=asuth
https://hg.mozilla.org/integration/autoland/rev/858d08371107
Stabilize cookiePolicy/cookiePermission for live documents - part 4 - Storage tests, r=asuth
https://hg.mozilla.org/integration/autoland/rev/b79ec111bf41
Stabilize cookiePolicy/cookiePermission for live documents - part 5 - BroadcastChannel must be blocked when cookie jar access is denied to avoid communication between live and new documents, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/d8ee13b6a17d
Stabilize cookiePolicy/cookiePermission for live documents - part 6 - Tests for SharedWorker and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/20f336320ce1
Stabilize cookiePolicy/cookiePermission for live documents - part 7 - Tests for IndexedDB and cookie settings changing, r=Ehsan,asuth
https://hg.mozilla.org/integration/autoland/rev/a565014fdd8d
Stabilize cookiePolicy/cookiePermission for live documents - part 8 - Tests for ServiceWorkers and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/d3e99dd3fc32
Stabilize cookiePolicy/cookiePermission for live documents - part 9 - Tests for DOM Cache and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/4cde0e38ada8
Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/1dcb31a1d5be
Stabilize cookiePolicy/cookiePermission for live documents - part 11 - windows/workers/documents must keep the current cookie settings and ignore changes, r=Ehsan
Backout by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc51c190590a
Backed out 11 changesets for failing at test_cookies_thirdparty.js on a CLOSED TREE.

Backed out 11 changesets (bug 1525245) for failing at test_cookies_thirdparty.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/bc51c190590a057206eb960e3eca6ac7461c36a3

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=230612240&revision=1dcb31a1d5be037dd32d9f9f46ccc79b7329f741

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=230612240&repo=autoland&lineNumber=1896

Log snippet:

[task 2019-02-26T20:04:12.092Z] 20:04:12 INFO - TEST-START | extensions/cookie/test/unit/test_cookies_thirdparty.js
[task 2019-02-26T20:04:12.415Z] 20:04:12 WARNING - TEST-UNEXPECTED-FAIL | extensions/cookie/test/unit/test_cookies_thirdparty.js | xpcshell return code: 0
[task 2019-02-26T20:04:12.416Z] 20:04:12 INFO - TEST-INFO took 320ms

Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6bdda622a04a
Stabilize cookiePolicy/cookiePermission for live documents - part 1 - information stored into loadInfo, r=Ehsan,ckerschb
https://hg.mozilla.org/integration/autoland/rev/d01ead2270e9
Stabilize cookiePolicy/cookiePermission for live documents - part 2 - AntiTracking, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/94295e3fb027
Stabilize cookiePolicy/cookiePermission for live documents - part 3 - LocalStorage and SessionStorage, r=asuth
https://hg.mozilla.org/integration/autoland/rev/43ad14e323a1
Stabilize cookiePolicy/cookiePermission for live documents - part 4 - Storage tests, r=asuth
https://hg.mozilla.org/integration/autoland/rev/476af2d7efe5
Stabilize cookiePolicy/cookiePermission for live documents - part 5 - BroadcastChannel must be blocked when cookie jar access is denied to avoid communication between live and new documents, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/6b92fb3666d1
Stabilize cookiePolicy/cookiePermission for live documents - part 6 - Tests for SharedWorker and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/10afd61b7582
Stabilize cookiePolicy/cookiePermission for live documents - part 7 - Tests for IndexedDB and cookie settings changing, r=Ehsan,asuth
https://hg.mozilla.org/integration/autoland/rev/d02e3f436390
Stabilize cookiePolicy/cookiePermission for live documents - part 8 - Tests for ServiceWorkers and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/38e802661b14
Stabilize cookiePolicy/cookiePermission for live documents - part 9 - Tests for DOM Cache and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/6a8401de3237
Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/efb2e8fca464
Stabilize cookiePolicy/cookiePermission for live documents - part 11 - windows/workers/documents must keep the current cookie settings and ignore changes, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/009e7457b990
Stabilize cookiePolicy/cookiePermission for live documents - part 12 - new CookieSettings for SharedWorkers and ServiceWorkers, r=Ehsan
Flags: needinfo?(amarchesini)
Backout by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/66a4a5cb3fc7
Backed out 12 changesets for failing worker-interception.https.html CLOSED TREE
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b89f5def8d0d
Stabilize cookiePolicy/cookiePermission for live documents - part 1 - information stored into loadInfo, r=Ehsan,ckerschb
https://hg.mozilla.org/integration/autoland/rev/e671fc9581eb
Stabilize cookiePolicy/cookiePermission for live documents - part 2 - AntiTracking, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/7e4f67a6d6f1
Stabilize cookiePolicy/cookiePermission for live documents - part 3 - LocalStorage and SessionStorage, r=asuth
https://hg.mozilla.org/integration/autoland/rev/1875eb5085e4
Stabilize cookiePolicy/cookiePermission for live documents - part 4 - Storage tests, r=asuth
https://hg.mozilla.org/integration/autoland/rev/bb6ade1207d7
Stabilize cookiePolicy/cookiePermission for live documents - part 5 - BroadcastChannel must be blocked when cookie jar access is denied to avoid communication between live and new documents, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/ffc10fdc50a6
Stabilize cookiePolicy/cookiePermission for live documents - part 6 - Tests for SharedWorker and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/2762bf88e050
Stabilize cookiePolicy/cookiePermission for live documents - part 7 - Tests for IndexedDB and cookie settings changing, r=Ehsan,asuth
https://hg.mozilla.org/integration/autoland/rev/fc3c64c330b9
Stabilize cookiePolicy/cookiePermission for live documents - part 8 - Tests for ServiceWorkers and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/2020227181cc
Stabilize cookiePolicy/cookiePermission for live documents - part 9 - Tests for DOM Cache and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/8ff9e8f45e02
Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/6aacd2d6e835
Stabilize cookiePolicy/cookiePermission for live documents - part 11 - windows/workers/documents must keep the current cookie settings and ignore changes, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/9da3ab33cf67
Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan
https://hg.mozilla.org/integration/autoland/rev/362f5a8d033c
Stabilize cookiePolicy/cookiePermission for live documents - part 13 - Cookies, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/835e5f642a03
Stabilize cookiePolicy/cookiePermission for live documents - part 14 - Test for cookies policy, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/0ef284a9a1d5
Stabilize cookiePolicy/cookiePermission for live documents - part 15 - Comments, r=asuth
https://hg.mozilla.org/integration/autoland/rev/9f8a1b410320
Stabilize cookiePolicy/cookiePermission for live documents - part 16 - Always grant storage permission for storage-access door hanger, r=johannh
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f72ba232cc8
Stabilize cookiePolicy/cookiePermission for live documents - part 1 - information stored into loadInfo, r=Ehsan,ckerschb
https://hg.mozilla.org/integration/autoland/rev/70bed2ad7899
Stabilize cookiePolicy/cookiePermission for live documents - part 2 - AntiTracking, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/0821b81f2724
Stabilize cookiePolicy/cookiePermission for live documents - part 3 - LocalStorage and SessionStorage, r=asuth
https://hg.mozilla.org/integration/autoland/rev/b3920c0bcf84
Stabilize cookiePolicy/cookiePermission for live documents - part 4 - Storage tests, r=asuth
https://hg.mozilla.org/integration/autoland/rev/abe4482fa137
Stabilize cookiePolicy/cookiePermission for live documents - part 5 - BroadcastChannel must be blocked when cookie jar access is denied to avoid communication between live and new documents, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/c2a13a7480e1
Stabilize cookiePolicy/cookiePermission for live documents - part 6 - Tests for SharedWorker and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/a91b7ebe8bdd
Stabilize cookiePolicy/cookiePermission for live documents - part 7 - Tests for IndexedDB and cookie settings changing, r=Ehsan,asuth
https://hg.mozilla.org/integration/autoland/rev/9affaf0cb998
Stabilize cookiePolicy/cookiePermission for live documents - part 8 - Tests for ServiceWorkers and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/4772db3625b3
Stabilize cookiePolicy/cookiePermission for live documents - part 9 - Tests for DOM Cache and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/fb90d51ba853
Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/66e19a0c38dd
Stabilize cookiePolicy/cookiePermission for live documents - part 11 - windows/workers/documents must keep the current cookie settings and ignore changes, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/a5a9e01116ed
Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan
https://hg.mozilla.org/integration/autoland/rev/6790802e2fa5
Stabilize cookiePolicy/cookiePermission for live documents - part 13 - Cookies, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/0e6f7be92e3f
Stabilize cookiePolicy/cookiePermission for live documents - part 14 - Test for cookies policy, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/d9a9e8e77873
Stabilize cookiePolicy/cookiePermission for live documents - part 15 - Comments, r=asuth
https://hg.mozilla.org/integration/autoland/rev/3fd27215698f
Stabilize cookiePolicy/cookiePermission for live documents - part 16 - Always grant storage permission for storage-access door hanger, r=johannh
Backout by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca64604d4b78
Backed out 16 changesets for perma failing test_document_cookie.html CLOSED TREE
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ccb173c27668
Stabilize cookiePolicy/cookiePermission for live documents - part 1 - information stored into loadInfo, r=Ehsan,ckerschb
https://hg.mozilla.org/integration/autoland/rev/c08a35a9c0d6
Stabilize cookiePolicy/cookiePermission for live documents - part 2 - AntiTracking, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/bfab5b97ae49
Stabilize cookiePolicy/cookiePermission for live documents - part 3 - LocalStorage and SessionStorage, r=asuth
https://hg.mozilla.org/integration/autoland/rev/7d3090c3f30b
Stabilize cookiePolicy/cookiePermission for live documents - part 4 - Storage tests, r=asuth
https://hg.mozilla.org/integration/autoland/rev/e3309d98e9bd
Stabilize cookiePolicy/cookiePermission for live documents - part 5 - BroadcastChannel must be blocked when cookie jar access is denied to avoid communication between live and new documents, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/174b0477055a
Stabilize cookiePolicy/cookiePermission for live documents - part 6 - Tests for SharedWorker and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/5f8af0d132c8
Stabilize cookiePolicy/cookiePermission for live documents - part 7 - Tests for IndexedDB and cookie settings changing, r=Ehsan,asuth
https://hg.mozilla.org/integration/autoland/rev/d778cbd509c3
Stabilize cookiePolicy/cookiePermission for live documents - part 8 - Tests for ServiceWorkers and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/89c5023dd68e
Stabilize cookiePolicy/cookiePermission for live documents - part 9 - Tests for DOM Cache and cookie settings changing, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/98ff0248c607
Stabilize cookiePolicy/cookiePermission for live documents - part 10 - Fix existing tests, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/c11d3680e3d1
Stabilize cookiePolicy/cookiePermission for live documents - part 11 - windows/workers/documents must keep the current cookie settings and ignore changes, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/8821567e070f
Stabilize cookiePolicy/cookiePermission for live documents - part 12 - nsICookieSettings for the channel creation, r=ckerschb,asuth,Ehsan
https://hg.mozilla.org/integration/autoland/rev/9111c85dd890
Stabilize cookiePolicy/cookiePermission for live documents - part 13 - Cookies, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/f7a3740e9d8e
Stabilize cookiePolicy/cookiePermission for live documents - part 14 - Test for cookies policy, r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/dd197c3722a0
Stabilize cookiePolicy/cookiePermission for live documents - part 15 - Comments, r=asuth
https://hg.mozilla.org/integration/autoland/rev/3cddc7cd4da5
Stabilize cookiePolicy/cookiePermission for live documents - part 16 - Always grant storage permission for storage-access door hanger, r=johannh
Flags: needinfo?(amarchesini)
See Also: → 1432325
Depends on: 1534538
Depends on: 1534343
Depends on: 1535380
Depends on: 1534340
Depends on: 1533394
Regressions: 1541339
Regressions: 1548585
Regressions: 1561654
Regressions: 1577196
Depends on: 1575934
No longer depends on: 1575934
Regressions: 1575934
You need to log in before you can comment on or make changes to this bug.