1525297 - Dedicated profile is not created.

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[ovidiu boca[:Ovidiu]]

Affected versions

• Nightly 67.0a1

Affected platforms

• Mac OS, Windows

Steps to reproduce

1. Install 2 builds with Dedicated Profile enabled
2. Open both of them at the same time or alternative
3. Go to about:profiles and check how many profiles are created.
   Expected result
   *Each build that has the Dedicated feature should have its own profile.

• There are 3 profiles: default, default-nightly and default-nightly-1
  NOTE: In this case, I used Nightly builds but if you use beta with Dedicated feature the profile name will change to default-beta.

Actual result
There are 2 profiles: default, default-nightly
The second build uses the default profile.

Additional notes

• We will test on Ubuntu and update the bug report.

Comment 1

[Dave Townsend [:mossop]]

This is a result of the fix for bug 1522751.

Comment 2

[Dave Townsend [:mossop]]

Attachment: Bug 1525297: Don't use empty profiles for dedicated profiles and don't show the welcome page in this case. r=froydnj

Using an old default profile that is empty (like from bug 1518591) causes us to
also show the user a welcome page when that isn't necessary.

Instead leave old empty profiles alone (older versions will use them as the
default), create a new profile but don't set the flag to say that the old
default was skipped.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c699c4e694a1
Don't use empty profiles for dedicated profiles and don't show the welcome page in this case. r=froydnj

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c699c4e694a1

Comment 5

[ovidiu boca[:Ovidiu]]

I verified this on multiple OSes and I have different results:

On Mac OS 10.14:

• if both installs are open at the same there are 3 profiles: default, default-nightly and default-nightly-1
• if the installs are open alternatively there are 3 profiles: default, default-nightly and default-nightly-1

On Windows 10 :

• if both installs are open at the same there are 2 profiles: default, default-nightly and when you open the second install a new window is open not a new profile.
• if the installs are open alternatively there are 3 profiles: default, default-nightly and default-nightly-1

On Ubuntu 16.04:

• if both installs are open at the same there are 2 profiles: default, default-nightly and when you open the second install a new window is open not a new profile.
• if the installs are open alternatively there are 3 profiles: default, default-nightly and default-nightly-1

Please let me know if I need to file a separate bug for this issue.

Comment 6

[Dave Townsend [:mossop]]

Are you running the second install with -no-remote? Until bug 1518639 is fixed what you describe is what I would expect without -no-remote.

Comment 7

[ovidiu boca[:Ovidiu]]

No, I don't use -no-remote, I've just opened them normally, double click on the icon.

Comment 8

[ovidiu boca[:Ovidiu]]

I verified this on Windows 10 and Ubuntu 16.04 with the latest Nightly 67.0a1(2019-03-07) and I can confirm the fix.