Missing error check when calling nsIFile::Exists() in nsToolkitProfileService::SelectStartupProfile()

RESOLVED FIXED in Firefox 67

Status

()

RESOLVED FIXED
a month ago
21 days ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks: 1 bug, {regression})

unspecified
mozilla67
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox65 unaffected, firefox66 unaffected, firefox67 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a month ago

Coverity points to this write-only rv variable https://searchfox.org/mozilla-central/rev/e6520f0a4dd5d7474c32a1164744953ea59be0d0/toolkit/profile/nsToolkitProfileService.cpp#1059 which points to missing error handling here.

Comment 2

28 days ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8231f78228bc
Add error handling for the call to nsIFile::Exists() in nsToolkitProfileService::SelectStartupProfile(); r=mossop

Comment 3

27 days ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 27 days ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → ehsan
status-firefox65: --- → unaffected
status-firefox66: --- → unaffected
status-firefox-esr60: --- → unaffected
You need to log in before you can comment on or make changes to this bug.