1525507 - Twitch VP9 in MP4 streams do not play

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Jean-Yves Avenard [:jya]]

There's an encoding error in Twitch's VP9 stream.

This is due to all frames being marked as keyframe even when they are not.

As such, when seeking the first frame encountered will typically not be a keyframe, and the VP9 decoder will choke on those.

We should do like we do with H264, that is to not trust the mp4 container to tell us if a frame is keyframe or not and only rely on sniffing the raw bytestream content.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1525507 - P1. Don't trust mp4 container to determine if a VP9 frame is a keyframe. r?bryce

Similar to what we do for H264 and for vp9 in webm, we parse the VP9 bytestream and check if a frame is a keyframe there instead.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28c58b8cd89f
P1. Don't trust mp4 container to determine if a VP9 frame is a keyframe. r=bryce

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/28c58b8cd89f

Comment 4

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 67.0a1 (2019.01.31) Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 67.0b18 on Win 10 x64, macOS 10.13.6 and Ubuntu 18.04 x64.