1525733 - Require rust 1.32

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

This should happen two weeks after bug 1515322 landed, therefore next Tuesday, February 12th.

Comment 1

[Ryan Hunt [:rhunt]]

Is it okay to land this now?

The rust update policy says that we'll require stable two weeks after release [1]. The release of 1.32 happened on January 17th [2], which would mean we could require 1.32 on January 31st.

It seems that bug 1515322 was delayed landing because of the soft freeze, but I'm not sure that means we need to delay this bug.

I ask this because we'd like to increase the minimum required version for cbindgen (a build requirement) to 1.32 [3].

[1] https://wiki.mozilla.org/Rust_Update_Policy_for_Firefox
[2] https://blog.rust-lang.org/2019/01/17/Rust-1.32.0.html
[3] https://github.com/eqrion/cbindgen/pull/271

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Yes, this should be okay to land.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1525733 - Require rust 1.32 to build.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5041739e5a5b
Require rust 1.32 to build. r=firefox-build-system-reviewers,ted

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5041739e5a5b

Comment 6

[Mike Hommey [:glandium]]

This undetectedly broke the minidump-stackwalk jobs.