1525737 - Remove XUL grid implementation

Status: RESOLVED FIXED

(Core :: XUL, task, P5)

Description

[Tim Nguyen :ntim]

rm -rf layout/xul/grid

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1525737 - Remove layout/xul/grid directory.

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1525737 - Remove support for XUL grid display values.

Depends on D53296

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1525737 - Remove/replace usages of XUL grid display values.

Comment 4

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d5bda81b3e220d7c6176162125df08e4af50198

Comment 5

[Mats Palmgren (inactive)]

Attachment: additonal fix

FYI, this is also needed, otherwise the linter complains the path does not exist.

Comment 6

[Mats Palmgren (inactive)]

Attachment: additonal fix 2

... and a few more things that can be removed.

Comment 7

[Tim Nguyen :ntim]

Comment on attachment 9185052 [details] [diff] [review]
additonal fix 2

Review of attachment 9185052 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for catching the unused bits!

::: layout/style/test/test_non_content_accessible_values.html
@@ -12,5 @@
>    ],
>    "display": [
> -    "-moz-grid",
> -    "-moz-grid-group",
> -    "-moz-grid-line",

I kept those originally because you don't want to expose these values to content even if the code is removed. That's probably an unlikely future issue though, so up to you whether you want to remove them.

Comment 8

[Mats Palmgren (inactive)]

(In reply to Tim Nguyen :ntim from comment #7)

I kept those originally because you don't want to expose these values to
content even if the code is removed.

There's not much value in testing display keywords that no longer exist in the style system, so I think we should remove them from this test. I don' think there's any risk that we'd add them back by accident.

Comment 9

[Mats Palmgren (inactive)]

We should probably let bug 1583696 bake for a while before landing this though, just in case some regression is found.

Comment 10

[Tim Nguyen :ntim]

Hi Richard & Magnus,

Just a heads up that there are XUL grid usages in the mail/extensions/openpgp directory.
There are also quite a few in the editor/ & suite/ directories, but I was told before this isn't maintained/used for TB?

If nothing goes wrong, this bug should land in Firefox 85. Thanks to everyone involved in helping make this a reality!

Comment 11

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8130b56db7893b00feb01795a1265edd705927d8

Comment 12

[Magnus Melin [:mkmelin]]

Thanks, I filed bug 1677427 about the final bits in Thunderbird. Yes, editor/ and suite/ are practically dead, and not used by Thunderbird.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bacd1b4ff62
Remove/replace usages of XUL grid display values. r=emilio
https://hg.mozilla.org/integration/autoland/rev/044d198df333
Remove support for XUL grid display values. r=emilio
https://hg.mozilla.org/integration/autoland/rev/517f352dbde7
Remove layout/xul/grid directory. r=emilio

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0bacd1b4ff6264741ade6ef8caa45fe7085683c5
https://hg.mozilla.org/mozilla-central/rev/044d198df33340ee7d81b06231896c1db972929e
https://hg.mozilla.org/mozilla-central/rev/517f352dbde71f4afff47e5bcaf38e063c4b3ca3