1525886 - Total MozMill failure on 2019-02-07: Exception: Sorry, cannot connect to jsbridge extension, port 24242

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

Not to be confused with bug 1523535.

First seen on today's Daily:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=69ccafbda3de5c6e379300472b1e9bc43b3d612a

Looking at the ~20 changesets that landed since the last successful run, it will be:
5cdb6156ddaf Andrew Swan — Bug 857458 Remove addon manager update.rdf support r=kmag:
https://hg.mozilla.org/mozilla-central/rev/5cdb6156ddaf

Looks like these ones
toolkit/mozapps/extensions/internal/RDFDataSource.jsm
toolkit/mozapps/extensions/internal/RDFManifestConverter.jsm
got removed, so that would of course break all restartless add-ons relying on this.

Maybe we just need to fork those two.

Oh, looks like we already forked one of them, see:
common/src/RDFManifestConverter.jsm
9 "resource://gre/modules/addons/RDFDataSource.jsm");

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/610b943be50e
Fork RDFDataSource.jsm to common/ after its removal in bug 857458. rs=bustage-fix DONTBUILD

Comment 2

[Jorg K (CEST = GMT+2)]

Not sure that there's a review required here. I did copy/paste ;-)

I tried a MozMill test, that passed.

Comment 3

[:aceman]

Do we need those to parse install.rdf of the extensions? Would we need to convert jsbridge and mozmill to Webextensions o drop the need for install.rdf?

Comment 4

[Jorg K (CEST = GMT+2)]

It's used for restartless add-ons.