1525999 - ./mach bootstrap for android suggests not specifying target, which triggers compilation failure

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Bobby Holley (:bholley)]

./mach bootstrap suggests [1] for a .mozconfig, which includes the following language:

For regular phones, no --target is needed

On my machine, this triggers the following error during the configure phase of compilation:

0:01.77 ERROR: Android system directory not found in [u'/Users/bholley/.mozbuild/android-ndk-r17b/platforms/android-16/arch-arm/usr/include', u'/Users/bholley/.mozbuild/android-ndk-r17b/sysroot/usr/include/armv7a-linux-androideabi'].

Since ndk/sysroot/usr/include/armv-linux-androideabi is a directory, but sysroot/usr/include/armv7a-linux-androideabi is not. This path is computed at [2] based on the target.

Setting:

ac_add_options --target=arm-linux-androideabi

as is done in [3], fixes the issue.

[1] https://searchfox.org/mozilla-central/rev/490ab7f9b84570573a49d7fa018673ce0d5ddf22/python/mozboot/mozboot/android.py#54
[2] https://searchfox.org/mozilla-central/rev/490ab7f9b84570573a49d7fa018673ce0d5ddf22/build/moz.configure/android-ndk.configure#185
[3] https://github.com/bdekoz/mozilla-configuration/blob/master/mozconfig.android.arm

Comment 1

[Bobby Holley (:bholley)]

I also had to remove the --with-java-bin-path at https://searchfox.org/mozilla-central/rev/490ab7f9b84570573a49d7fa018673ce0d5ddf22/python/mozboot/mozboot/android.py#311

Comment 2

[Mike Hommey [:glandium]]

I've had this problem yesterday and was about to file a bug for it too. Essentially any valid arm-android target that is not arm-linux-androideabi fails.

Comment 3

[Mike Hommey [:glandium]]

Making this work generically with --target=armv7a is kind of entangled with bug 1524429, so I'll just go with the easy fix for now.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1525999 - Default to arm instead of armv7a for android builds.

That makes target.toolchain match what the NDK provides.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51697f8232c5
Default to arm instead of armv7a for android builds. r=nalexander

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out changeset 51697f8232c5 (Bug 1525999) for causing multiple Android failures on build/target.raptor.tests.tar.gz CLOSED TREES

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=51697f8232c5a2d5409edd5708769290c0f05833&selectedJob=227216685

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=227216685&repo=autoland&lineNumber=3743

Backout: https://hg.mozilla.org/integration/autoland/rev/857e68faa7053813602e2193aa33068204f0e844

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6914810e2aa0
Default to arm instead of armv7a for android builds. r=nalexander

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6914810e2aa0

Comment 9

[Nick Alexander :nalexander [he/him]]

Clearing NI: Mike relanded this.