1526084 - Android 7.0 x86_64 perma-fail testing/marionette/harness/marionette_harness/tests/unit/test_capabilities.py TestCapabilities.test_additional_capabilities | AssertionError: u'/storage/emulated/0/tests/profile' != '/storage/self/primary/tests/profile'

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P1)

Description

[Geoff Brown [:gbrown]]

Bug 1500509 contemplates running marionette tests on the Android 7.0 x86_64 platform. When we try, a few failures are seen, such as this:

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=226972037&repo=try&lineNumber=1652

[task 2019-02-07T22:20:59.550Z] 22:20:59 WARNING - TEST-UNEXPECTED-FAIL | testing/marionette/harness/marionette_harness/tests/unit/test_capabilities.py TestCapabilities.test_additional_capabilities | AssertionError: u'/storage/emulated/0/tests/profile' != '/storage/self/primary/tests/profile'
[task 2019-02-07T22:20:59.550Z] 22:20:59 INFO - Traceback (most recent call last):
[task 2019-02-07T22:20:59.551Z] 22:20:59 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_harness/marionette_test/testcases.py", line 159, in run
[task 2019-02-07T22:20:59.551Z] 22:20:59 INFO - testMethod()
[task 2019-02-07T22:20:59.551Z] 22:20:59 INFO - File "/builds/worker/workspace/build/tests/marionette/tests/testing/marionette/harness/marionette_harness/tests/unit/test_capabilities.py", line 97, in test_additional_capabilities
[task 2019-02-07T22:20:59.551Z] 22:20:59 INFO - self.assertEqual(self.caps["moz:profile"].lower(), current_profile.lower())
[task 2019-02-07T22:20:59.551Z] 22:20:59 INFO - TEST-INFO took 325ms

Bug 1456520 resolved a similar problem.

Comment 1

[Geoff Brown [:gbrown]]

The issue is that, in this environment, there are multiple layers of links before we get to the actual sdcard directory:

[task 2019-02-07T23:19:57.315Z] 23:19:57 INFO - ls=lrwxrwxrwx 1 root root 21 1970-01-01 01:00 /sdcard -> /storage/self/primary
[task 2019-02-07T23:19:57.421Z] 23:19:57 INFO - ls=lrwxrwxrwx 1 root root 19 2019-02-07 23:18 /storage/self/primary -> /mnt/user/0/primary
[task 2019-02-07T23:19:57.524Z] 23:19:57 INFO - ls=lrwxrwxrwx 1 root root 19 2019-02-07 23:19 /mnt/user/0/primary -> /storage/emulated/0

Comment 2

[Geoff Brown [:gbrown]]

Attachment: allow for multiple links to sdcard

This uses the same approach as before, but loops to find the true location in the filesystem.

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=ce5b2c85e718a1c8a635d3f7a48d89d128f67ab1

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=e8dec58015382bd6af9da0610cd1a8edba9c3b3a

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Geoff Brown [:gbrown] from comment #1)

The issue is that, in this environment, there are multiple layers of links before we get to the actual sdcard directory:

[task 2019-02-07T23:19:57.315Z] 23:19:57 INFO - ls=lrwxrwxrwx 1 root root 21 1970-01-01 01:00 /sdcard -> /storage/self/primary
[task 2019-02-07T23:19:57.421Z] 23:19:57 INFO - ls=lrwxrwxrwx 1 root root 19 2019-02-07 23:18 /storage/self/primary -> /mnt/user/0/primary
[task 2019-02-07T23:19:57.524Z] 23:19:57 INFO - ls=lrwxrwxrwx 1 root root 19 2019-02-07 23:19 /mnt/user/0/primary -> /storage/emulated/0

So could we run a Python script on the device which would simply print out the return value from os.path.realpath()?

Comment 4

[Geoff Brown [:gbrown]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #3)

So could we run a Python script on the device which would simply print out the return value from os.path.realpath()?

Yes, I think that would work, but we don't normally have Python available on Android devices.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I see. So we will have to use the shell. In that case I will review your patch soon.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb96244f54b1
In Mn test_capabilities.py, allow for multiple links to sdcard; r=whimboo

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cb96244f54b1