1526211 - no search engine chooseable or working on trunk

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[ruediger]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

Mark a word in a message, choose in right-click-menu 'Search Bing For...' waiting for Firefox with the search-results from bing.

In 'Options->General->Default Search Engine' no engine is displayed.

Actual results:

Nothing happens. The function is death.

Expected results:

Firefox opens with the search-results from bing.

Last good here: 20190202093057
First bad here: 20190203080026

Comment 1

[Wayne Mery (:wsmwk)]

I'm not running nightly so I haven't tested this myself

Comment 2

[Jorg K (CEST = GMT+2)]

Thanks for using Daily, but mind you English ;-) - Maybe the function is dead, but certainly not death.

Looks like bug 1492475:
https://hg.mozilla.org/mozilla-central/rev/add76bbdce4e

Aceman, do you have time to do the necessary tweaks here?

Comment 3

[Magnus Melin [:mkmelin]]

I'll take this

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1526211_search_engine_async.patch

I guess you're the last to have touched this. Want to review it?

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: bug1526211_search_engine_async.patch (JK)

Any reason not to repeat the Services.search.init().then(async () => { stuff? This seems to work for me.

BTW, commit message should be:
Bug 1526211 - Port bug 1492475: Switch to new search engine async API. r=jorgk

Comment 6

[ruediger]

(In reply to Jorg K (GMT+1) from comment #2)

Thanks for using Daily, but mind you English ;-) - Maybe the function is dead, but certainly not death.

Ouch... :-) But thanks for your attention.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9042652 [details] [diff] [review]
bug1526211_search_engine_async.patch (JK)

Review of attachment 9042652 [details] [diff] [review]:
-----------------------------------------------------------------

Both ways work just the same. I don't really have any strong preference for either one.

Comment 8

[Jorg K (CEST = GMT+2)]

Thanks, for simple minds like myself it might be preferable to use the same "pattern" in both places.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dc5b2c3dcf45
Port bug 1492475: Switch to new search engine async API. r=jorgk