[RTL] Mirror Firefox's default and lightweight theme icons on about:addons

VERIFIED FIXED in Firefox 67

Status

()

defect
P5
normal
VERIFIED FIXED
3 months ago
3 months ago

People

(Reporter: itiel_yn8, Assigned: jawad, Mentored, NeedInfo)

Tracking

({rtl})

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 verified)

Details

(Whiteboard: [lang=css])

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

3 months ago
Posted image Before/after

This bug is very similar to bug 1362841.

In about:addons Themes section, the built-in themes icons are LTR also for RTL locales.
Adding the following code:

.content-container > .icon-container > .icon:-moz-locale-dir(rtl) {
transform: scaleX(-1);
}

around here:
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/extensions/extensions.inc.css#475
...seems to fully fix it.
See attached before/after.

(Reporter)

Comment 1

3 months ago

:ddurst, can this bug be set as GFB (not for me though) and mentored by someone, assuming the CSS code above looks okay to you?

Flags: needinfo?(ddurst)

Comment 2

3 months ago

Happy to mentor this.

comment #0 is the right place and the right way to detect RTL-ness. However, we should apply the same fix for the detail view, when it's showing the details of a theme.

This is probably a little too tricky to just make gfb, so let's just have it as a mentored bug for now.

Mentor: gijskruitbosch+bugs
Flags: needinfo?(ddurst)
Whiteboard: [lang=css]

Comment 3

3 months ago

what is LTR and RTL?

Comment 4

3 months ago

(In reply to jeelpatel238 from comment #3)

what is LTR and RTL?

https://www.google.com/search?client=firefox-b-d&q=what+is+ltr+and+rtl

Priority: -- → P5

I was going to say that the one-off nature of this would qualify as a WONTFIX for us, but considering it has interest and a mentor, we'll just P5 it and leave it off our triage.

Comment 6

3 months ago

(In reply to :Gijs (he/him) from comment #2)

Happy to mentor this.

comment #0 is the right place and the right way to detect RTL-ness. However, we should apply the same fix for the detail view, when it's showing the details of a theme.

This is probably a little too tricky to just make gfb, so let's just have it as a mentored bug for now.

Hi,

I am an Outreachy applicant and would love to work on this bug! Can you please help me on how to get started?

Comment 7

3 months ago

(In reply to Debu from comment #6)

(In reply to :Gijs (he/him) from comment #2)

Happy to mentor this.

comment #0 is the right place and the right way to detect RTL-ness. However, we should apply the same fix for the detail view, when it's showing the details of a theme.

This is probably a little too tricky to just make gfb, so let's just have it as a mentored bug for now.

Hi,

I am an Outreachy applicant and would love to work on this bug! Can you please help me on how to get started?

Sure. You'll need an artifact build of Firefox (see https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build and https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds ). A searchable copy of the source code is at http://searchfox.org/ . comment #0 has some specific ideas about where to look for the issue. You can test RTL by switching intl.uidirection in about:config to the value 1. Let me know if you have specific questions; you can also ask for help in the #introduction channel on IRC ( https://wiki.mozilla.org/IRC )

Comment 8

3 months ago

(In reply to :Gijs (he/him) from comment #7)

(In reply to Debu from comment #6)

(In reply to :Gijs (he/him) from comment #2)

Happy to mentor this.

comment #0 is the right place and the right way to detect RTL-ness. However, we should apply the same fix for the detail view, when it's showing the details of a theme.

This is probably a little too tricky to just make gfb, so let's just have it as a mentored bug for now.

Hi,

I am an Outreachy applicant and would love to work on this bug! Can you please help me on how to get started?

Sure. You'll need an artifact build of Firefox (see https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build and https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds ). A searchable copy of the source code is at http://searchfox.org/ . comment #0 has some specific ideas about where to look for the issue. You can test RTL by switching intl.uidirection in about:config to the value 1. Let me know if you have specific questions; you can also ask for help in the #introduction channel on IRC ( https://wiki.mozilla.org/IRC )

I am facing some problem in building ./mach
An error pops up saying:
0:05.41 ERROR: Cannot find the target C compiler
0:05.49 *** Fix above errors and then restart with
0:05.49 "./mach build"

I looked up the issue in internet and according to this https://bugzilla.mozilla.org/show_bug.cgi?id=1306395 I tried to create and configure .mozconfig file but its still not working. I'm stuck.

(Assignee)

Comment 9

3 months ago

Hi, I am willing to work on this bug, please assign it to me.

(Assignee)

Comment 10

3 months ago

Hi, i have this patch ready for submission, please assign this bug to me.

Attachment #9046805 - Flags: review?(gijskruitbosch+bugs)
(Assignee)

Comment 11

3 months ago
Posted image patch_result.png

Comment 12

3 months ago
Comment on attachment 9046805 [details] [diff] [review]
Mirroring Firefox's default and lightweight theme icons on about:addons

Jawad, please can you submit via phabricator instead?

Debu: did you get your issue resolved?
Flags: needinfo?(debsdo101)
Attachment #9046805 - Flags: review?(gijskruitbosch+bugs)
Attachment #9047659 - Attachment is obsolete: true
Attachment #9047561 - Attachment is obsolete: true
Attachment #9047561 - Attachment is obsolete: false

Comment 15

3 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a193a626803d
Mirroring Firefox's default and lightweight theme icons on about:addons. r=Gijs

Comment 16

3 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Updated

3 months ago
Assignee: nobody → ijawadak
(Reporter)

Comment 17

3 months ago

Looking good on latest Nightly. Thanks!

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.