1526269 - [RTL] Mirror Firefox's default and lightweight theme icons on about:addons

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Itiel]

Attachment: Before/after

This bug is very similar to bug 1362841.

In about:addons Themes section, the built-in themes icons are LTR also for RTL locales.
Adding the following code:

.content-container > .icon-container > .icon:-moz-locale-dir(rtl) {
transform: scaleX(-1);
}

around here:
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/extensions/extensions.inc.css#475
...seems to fully fix it.
See attached before/after.

Comment 1

[Itiel]

:ddurst, can this bug be set as GFB (not for me though) and mentored by someone, assuming the CSS code above looks okay to you?

Comment 2

[:Gijs (he/him)]

Happy to mentor this.

comment #0 is the right place and the right way to detect RTL-ness. However, we should apply the same fix for the detail view, when it's showing the details of a theme.

This is probably a little too tricky to just make gfb, so let's just have it as a mentored bug for now.

Comment 3

[jeelpatel238]

what is LTR and RTL?

Comment 4

[:Gijs (he/him)]

(In reply to jeelpatel238 from comment #3)

what is LTR and RTL?

https://www.google.com/search?client=firefox-b-d&q=what+is+ltr+and+rtl

Comment 5

[David Durst [:ddurst]]

I was going to say that the one-off nature of this would qualify as a WONTFIX for us, but considering it has interest and a mentor, we'll just P5 it and leave it off our triage.

Comment 6

[Debu]

(In reply to :Gijs (he/him) from comment #2)

Happy to mentor this.

comment #0 is the right place and the right way to detect RTL-ness. However, we should apply the same fix for the detail view, when it's showing the details of a theme.

This is probably a little too tricky to just make gfb, so let's just have it as a mentored bug for now.

Hi,

I am an Outreachy applicant and would love to work on this bug! Can you please help me on how to get started?

Comment 7

[:Gijs (he/him)]

(In reply to Debu from comment #6)

(In reply to :Gijs (he/him) from comment #2)

Happy to mentor this.

comment #0 is the right place and the right way to detect RTL-ness. However, we should apply the same fix for the detail view, when it's showing the details of a theme.

This is probably a little too tricky to just make gfb, so let's just have it as a mentored bug for now.

Hi,

I am an Outreachy applicant and would love to work on this bug! Can you please help me on how to get started?

Sure. You'll need an artifact build of Firefox (see https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build and https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds ). A searchable copy of the source code is at http://searchfox.org/ . comment #0 has some specific ideas about where to look for the issue. You can test RTL by switching intl.uidirection in about:config to the value 1. Let me know if you have specific questions; you can also ask for help in the #introduction channel on IRC ( https://wiki.mozilla.org/IRC )

Comment 8

[Debu]

(In reply to :Gijs (he/him) from comment #7)

(In reply to Debu from comment #6)

(In reply to :Gijs (he/him) from comment #2)

Happy to mentor this.

comment #0 is the right place and the right way to detect RTL-ness. However, we should apply the same fix for the detail view, when it's showing the details of a theme.

This is probably a little too tricky to just make gfb, so let's just have it as a mentored bug for now.

Hi,

I am an Outreachy applicant and would love to work on this bug! Can you please help me on how to get started?

Sure. You'll need an artifact build of Firefox (see https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build and https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds ). A searchable copy of the source code is at http://searchfox.org/ . comment #0 has some specific ideas about where to look for the issue. You can test RTL by switching intl.uidirection in about:config to the value 1. Let me know if you have specific questions; you can also ask for help in the #introduction channel on IRC ( https://wiki.mozilla.org/IRC )

I am facing some problem in building ./mach
An error pops up saying:
0:05.41 ERROR: Cannot find the target C compiler
0:05.49 *** Fix above errors and then restart with
0:05.49 "./mach build"

I looked up the issue in internet and according to this https://bugzilla.mozilla.org/show_bug.cgi?id=1306395 I tried to create and configure .mozconfig file but its still not working. I'm stuck.

Comment 9

[Jawad Ahmed [:jawad]]

Hi, I am willing to work on this bug, please assign it to me.

Comment 10

[Jawad Ahmed [:jawad]]

Attachment: Mirroring Firefox's default and lightweight theme icons on about:addons

Hi, i have this patch ready for submission, please assign this bug to me.

Comment 11

[Jawad Ahmed [:jawad]]

Attachment: patch_result.png

Comment 12

[:Gijs (he/him)]

Comment on attachment 9046805 [details] [diff] [review]
Mirroring Firefox's default and lightweight theme icons on about:addons

Jawad, please can you submit via phabricator instead?

Debu: did you get your issue resolved?

Comment 13

[Jawad Ahmed [:jawad]]

Attachment: Bug 1526269 - Mirroring Firefox's default and lightweight theme icons on about:addons. r=gijs

Comment 14

[Jawad Ahmed [:jawad]]

Attachment: Bug 1526269 - Fixed icon just mirrored in themes - Mirroring Firefox's default and lightweight theme icons on about:addons. r=gijs

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a193a626803d
Mirroring Firefox's default and lightweight theme icons on about:addons. r=Gijs

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a193a626803d

Comment 17

[Itiel]

Looking good on latest Nightly. Thanks!