Closed Bug 1526417 Opened 6 years ago Closed 6 years ago

failure in browser_bookmark_popup.js when running on windows 10 v.1803

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jmaher, Unassigned)

References

Details

We are in the process of updating our version of windows that we use for testing from 1703 to 1803.

In doing so, we find some failures, specifically this one:
browser_bookmark_popup.js

here is a try push (windows 10 opt bc1 job):
https://treeherder.mozilla.org/#/jobs?repo=try&searchStr=browser-chrome&revision=937618e6864c12a65574d5ead32e4a614a7c957d&selectedJob=226457063

and a log:
https://taskcluster-artifacts.net/fFyRxgjVRS2K_lp95uZaqQ/0/public/logs/live_backing.log

and related information from the log:
11:07:41 INFO - TEST-PASS | browser/base/content/test/general/browser_bookmark_popup.js | Page should only be starred prior to popupshown if editing bookmark - false == false -
11:07:41 INFO - TEST-PASS | browser/base/content/test/general/browser_bookmark_popup.js | Panel should be 'closed' to start test - "closed" == "closed" -
11:07:41 INFO - Buffered messages logged at 11:06:57
11:07:41 INFO - TEST-PASS | browser/base/content/test/general/browser_bookmark_popup.js | Panel should be 'open' after shownPromise is resolved - "open" == "open" -
11:07:41 INFO - TEST-PASS | browser/base/content/test/general/browser_bookmark_popup.js | Only one bookmark should exist - 1 == 1 -
11:07:41 INFO - TEST-PASS | browser/base/content/test/general/browser_bookmark_popup.js | Page is starred - "true" == "true" -
11:07:41 INFO - TEST-PASS | browser/base/content/test/general/browser_bookmark_popup.js | title should match isEditingBookmark state - "New Bookmark" == "New Bookmark" -
11:07:41 INFO - TEST-PASS | browser/base/content/test/general/browser_bookmark_popup.js | remove/cancel button label should match isEditingBookmark state - "Cancel" == "Cancel" -
11:07:41 INFO - Buffered messages finished
11:07:41 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | Test timed out -
11:07:41 INFO - GECKO(8944) | MEMORY STAT | vsize 5952MB | vsizeMaxContiguous 69034201MB | residentFast 236MB | heapAllocated 75MB
11:07:41 INFO - TEST-OK | browser/base/content/test/general/browser_bookmark_popup.js | took 45022ms
11:07:41 INFO - Not taking screenshot here: see the one that was previously logged
11:07:41 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | Found a tab after previous test timed out: data:text/html,<html><body></body></html> -
11:07:41 INFO - checking window state
11:07:41 INFO - TEST-START | browser/base/content/test/general/browser_bookmark_titles.js
11:07:41 INFO - Not taking screenshot here: see the one that was previously logged
11:07:41 INFO - Buffered messages logged at 11:07:41
11:07:41 INFO - Entering test bound check_default_bookmark_title
11:07:41 INFO - Buffered messages finished
11:07:41 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bookmark_popup.js | Uncaught exception received from previously timed out test - at chrome://mochitests/content/browser/browser/base/content/test/general/browser_bookmark_popup.js:104 - TypeError: Assert is null

Component: General → Bookmarks & History

The test times out here as we're waiting for an automatic close of the popup. I'm not sure I'd see why that would happen on a new windows version and not other platforms.

The cases where it could abort the automatic close are:

  • Mouse is hovering over the popup
  • Mouse click
  • Keyboard press

The only other thing would be setTimeout, but I think that unlikely.

iirc we used to have things set up quite strictly for resolutions, mouse locations, keyboards etc - have they all been set up the same here, especially the mouse location?

I also note there's another app in the background, I thought we didn't normally have other apps running.

Flags: needinfo?(jmaher)

I might have figured this out- we should have the mouse/resolution done, but we didn't on my try pushes (my fault), let me retest!

Depends on: 1527369

ok, I had accidentally turned off the mouse and screen resolution script causing this test to fail- re-enabling in bug 1527369

Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(jmaher)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.