1526452 - Stop committing Activity Stream source maps to mozilla-central

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Kate Hudson :k88hudson]

I'd like to propose no longer committing source maps for our bundled CSS / JS files in MC.

We can continue to support this for local dev (via startmc perhaps), but removing them from our exports will:

• Make exports easier to read
• Drastically reduce the chance of merge conflicts between uplifts/exports

The downside of this is that we'll no longer have as fine-grained line numbers from debugging directly in nightly etc., but I'd argue that most of our development happens locally anyway and our bundled files are readable enough that we'd still be able to track down a compiled line-number if we needed to.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4783

Comment 2

[Ed Lee :Mardak]

As a side note, beta+ users opening devtools on about:newtab will no longer see:

Source map error: TypeError: NetworkError when attempting to fetch resource.
Resource URL: resource://activity-stream/data/content/activity-stream.bundle.js

Source map error: TypeError: NetworkError when attempting to fetch resource.
Resource URL: resource://activity-stream/css/activity-stream.css

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/f98b2b564191