1526477 - Firefox failing to nominate ICE pairs when interoping with an ice-lite endpoint

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Byron Campen [:bwc]]

Observed over in bug 1525802. Maybe we're trying to do regular nomination, but failing?

Comment 1

[Byron Campen [:bwc]]

Yeah, we're definitely getting confused on an ICE restart with ice-lite, and thinking we're in the controlled role.

Comment 2

[Byron Campen [:bwc]]

Here's our bug: https://searchfox.org/mozilla-central/source/media/mtransport/third_party/nICEr/src/ice/ice_parser.c#495

Looks like this code was compensating for it, but only on the initial ICE: https://searchfox.org/mozilla-central/source/media/mtransport/nricectx.cpp#784

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1526477 - Part 0: Test role for ice-lite cases.

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 1526477 - Part 1: Fix typo causing us to go into the controlled role when interoping with an ice-lite endpoint.

Depends on D19232

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecfd9a5e2c733b9f724e3a9de0ca65cb2db0d64e

Comment 6

[Byron Campen [:bwc]]

Ugh. Looks like the try push never actually made it into CI somehow.

Comment 7

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff97546cbbcdb0c47ef41f67ae8b1b06e958c9bb

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07d21448117d
Part 0: Test role for ice-lite cases. r=mjf
https://hg.mozilla.org/integration/autoland/rev/40fbc56a0763
Part 1: Fix typo causing us to go into the controlled role when interoping with an ice-lite endpoint. r=mjf

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/07d21448117d
https://hg.mozilla.org/mozilla-central/rev/40fbc56a0763

Comment 11

[Nils Ohlmeier [:drno]]

Byron, can request uplift of this (looks like an easy fix)?

Comment 12

[Byron Campen [:bwc]]

Comment on attachment 9042658 [details]
Bug 1526477 - Part 1: Fix typo causing us to go into the controlled role when interoping with an ice-lite endpoint.

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1486012
• User impact if declined: Some webrtc services will break.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Extremely low risk; just changing the value of a bool (this bool regularly takes both possible values).
• String changes made/needed: None.

Comment 13

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 9042658 [details]
Bug 1526477 - Part 1: Fix typo causing us to go into the controlled role when interoping with an ice-lite endpoint.

Typo fix for regression from 64.
OK for uplift for beta 13.

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d380e82c33fb

Comment 16

[Cornel Ionce [:noni]]

(In reply to Byron Campen [:bwc] from comment #12)

• Is this code covered by automated tests?: Yes
• Needs manual test from QE?: No

Setting qe-verify flag to [-] per comment 12.