Firefox failing to nominate ICE pairs when interoping with an ice-lite endpoint
Categories
(Core :: WebRTC: Networking, defect, P2)
Tracking
()
People
(Reporter: bwc, Assigned: bwc)
References
Details
Attachments
(2 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details | Review |
Observed over in bug 1525802. Maybe we're trying to do regular nomination, but failing?
Assignee | ||
Comment 1•5 years ago
|
||
Yeah, we're definitely getting confused on an ICE restart with ice-lite, and thinking we're in the controlled role.
Assignee | ||
Comment 2•5 years ago
|
||
Here's our bug: https://searchfox.org/mozilla-central/source/media/mtransport/third_party/nICEr/src/ice/ice_parser.c#495
Looks like this code was compensating for it, but only on the initial ICE: https://searchfox.org/mozilla-central/source/media/mtransport/nricectx.cpp#784
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D19232
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecfd9a5e2c733b9f724e3a9de0ca65cb2db0d64e
Updated•5 years ago
|
Assignee | ||
Comment 6•5 years ago
|
||
Ugh. Looks like the try push never actually made it into CI somehow.
Assignee | ||
Comment 7•5 years ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/07d21448117d Part 0: Test role for ice-lite cases. r=mjf https://hg.mozilla.org/integration/autoland/rev/40fbc56a0763 Part 1: Fix typo causing us to go into the controlled role when interoping with an ice-lite endpoint. r=mjf
Comment 9•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/07d21448117d
https://hg.mozilla.org/mozilla-central/rev/40fbc56a0763
Comment 11•5 years ago
|
||
Byron, can request uplift of this (looks like an easy fix)?
Assignee | ||
Comment 12•5 years ago
|
||
Comment on attachment 9042658 [details]
Bug 1526477 - Part 1: Fix typo causing us to go into the controlled role when interoping with an ice-lite endpoint.
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: Bug 1486012
- User impact if declined: Some webrtc services will break.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Extremely low risk; just changing the value of a bool (this bool regularly takes both possible values).
- String changes made/needed: None.
Updated•5 years ago
|
Comment 13•5 years ago
|
||
Comment on attachment 9042658 [details]
Bug 1526477 - Part 1: Fix typo causing us to go into the controlled role when interoping with an ice-lite endpoint.
Typo fix for regression from 64.
OK for uplift for beta 13.
Comment 15•5 years ago
|
||
bugherder uplift |
Comment 16•5 years ago
|
||
(In reply to Byron Campen [:bwc] from comment #12)
- Is this code covered by automated tests?: Yes
- Needs manual test from QE?: No
Setting qe-verify flag to [-] per comment 12.
Description
•