1526512 - WebRTC RTCP stat roundTripTime is expressed in milliseconds not in (double) seconds

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P3)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

According to the spec the remote-inbound-rtp stat roundTripTime should be expressed in units of seconds, not milliseconds as it currently is. Both Chrome and Safari currently implement this in units of seconds, though it is on the wrong dictionary. This is probably a mitigating factor for us in avoiding breakage while fixing this stat.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

This does not appear to be a regression.

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1526512 - remote-inbound-rtp stat roundTripTime should be expressed in seconds

Changing the units roundTripTime is reported in from milliseconds to seconds

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bcfb521f4b4852c47309f7a5120fc2cd170332c1

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Spec review notes:
According to the spec[0] roundTripTime should be a double not a long.
[0] https://w3c.github.io/webrtc-stats/#dom-rtcremoteinboundrtpstreamstats-roundtriptime

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f38e97f40ef
remote-inbound-rtp stat roundTripTime should be expressed in seconds r=jib,smaug

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5f38e97f40ef