Closed Bug 1524642 Opened 9 months ago Closed 8 months ago

RTCRtpTransceiver wpt has been quietly disabled

Categories

(Core :: WebRTC: Signaling, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: bwc, Assigned: bwc)

References

Details

Attachments

(2 files)

It sure would be great if someone would let me know before they disable one of my tests...

Assignee: nobody → docfaraday
Rank: 10
Priority: -- → P1

When I try to re-enable our tests, I trip over bug 1522773.

Depends on: 1522773
Blocks: 1521879
Blocks: 1402912
Blocks: 1508685
Blocks: 1490658
Depends on: 1522535

I'm assuming the webkit patch in bug 1514432 busted this test for us and made it quietly disabled on the following metadata sync. James, can problems like this be mitigated somehow? Like automatic filing of a bug when a WPT-sync makes our support for a WPT-test worse?

Blocks: 1514432
Flags: needinfo?(james)

The intent is that there is always a bug when something is disabled. In this case a harness change caused a bunch of new instability, blocking all wpt imports. In the scramble to fix that some bugs that ought to have been filed weren't.

So this situation already isn't supposed to happen, and I'm also working on tooling to give people better insights into the status of web-platform-tests in general so it will be even harder for something like this to happen again without people becoming aware.

Flags: needinfo?(james)

(In reply to Andreas Pehrson [:pehrsons] from comment #12)

I'm assuming the webkit patch in bug 1514432 busted this test for us and made it quietly disabled on the following metadata sync. James, can problems like this be mitigated somehow? Like automatic filing of a bug when a WPT-sync makes our support for a WPT-test worse?

This was one of the problems, but there are much worse things that broke. I am trying to fix/compensate for them here.

Blocks: 1526512
No longer blocks: 1526512
Attachment #9043370 - Attachment description: Bug 1524642: Re-enable/fix some webrtc wpt, and make a small spec fix. r?jib → Bug 1524642 - Part 1: Re-enable/fix some webrtc wpt. r?jib
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1318991460b3
Part 1: Re-enable/fix some webrtc wpt. r=jib
https://hg.mozilla.org/integration/autoland/rev/804dc60558df
Part 2: In getReceivers/Senders, do not include stopped transceivers. r=jib
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15416 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/15416
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/DM56lTwGQbmX5A_x_WCNwg)

This didn't merge upstream for failures in Firefox stability checking. I can force-merge the changes if you like, but it seems like there are still real issues to figure out with this test.

See Also: → 1528323
You need to log in before you can comment on or make changes to this bug.