1526654 - Running a single failing xpcshell test for debugging shouldn't run it twice

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect, P2)

Description

[Florian Quèze [:florian]]

When attempting to debug an xpcshell test to debug it using ./mach test <path>.js, the test runs and fails, and then is ran a second time after the "Retrying tests that failed when run in parallel" message.

Apparently this was already fixed once in bug 969633.

Comment 1

[Geoff Brown [:gbrown]]

The earlier fix looks appropriate. I think it was accidentally lost in bug 1209312.

Comment 2

[Geoff Brown [:gbrown]]

Attachment: Bug 1526654 - Use xpcshell sequential mode consistently when running a single test; r=bc

In the harness, sequential mode is set when self.singleFile is set. self.singleFile has
been set correctly when a single test is specified as a test_path (mach xpcshell-test <test>)
but it has not been set correctly if a single test is specified in a manifest (mach test <test);
this patch corrects for that by setting self.singleFile after all test specifications have
set self.alltests.

An unintended consequence of the code rearrangement is that the chunk_by_slice filter is
now used even when self.singleFile would be set -- but only if totalChunks > 1; this
situation seems very unlikely, and the consequences minimal.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8130ba1701bb
Use xpcshell sequential mode consistently when running a single test; r=bc

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8130ba1701bb