Running a single failing xpcshell test for debugging shouldn't run it twice

RESOLVED FIXED in Firefox 67

Status

defect
P2
normal
RESOLVED FIXED
4 months ago
2 months ago

People

(Reporter: florian, Assigned: gbrown)

Tracking

Version 3
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

4 months ago

When attempting to debug an xpcshell test to debug it using ./mach test <path>.js, the test runs and fails, and then is ran a second time after the "Retrying tests that failed when run in parallel" message.

Apparently this was already fixed once in bug 969633.

Assignee

Comment 1

3 months ago

The earlier fix looks appropriate. I think it was accidentally lost in bug 1209312.

Assignee: nobody → gbrown
Assignee

Updated

3 months ago
Priority: -- → P2
Assignee

Comment 2

2 months ago

In the harness, sequential mode is set when self.singleFile is set. self.singleFile has
been set correctly when a single test is specified as a test_path (mach xpcshell-test <test>)
but it has not been set correctly if a single test is specified in a manifest (mach test <test);
this patch corrects for that by setting self.singleFile after all test specifications have
set self.alltests.

An unintended consequence of the code rearrangement is that the chunk_by_slice filter is
now used even when self.singleFile would be set -- but only if totalChunks > 1; this
situation seems very unlikely, and the consequences minimal.

Comment 3

2 months ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8130ba1701bb
Use xpcshell sequential mode consistently when running a single test; r=bc

Comment 4

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.