Should we make default of "wheel" (and "DOMMouseScroll", "MozPixelMouseScroll") event listeners on root "passive"?
Categories
(Core :: DOM: Events, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: masayuki, Assigned: emilio)
References
(Blocks 1 open bug, )
Details
(Keywords: dev-doc-complete)
Attachments
(3 files)
According to the blog-post, Chrome 73 starts to treat "wheel" and "mousewheel" event listeners on root as passive event listeners by default like touchstart and touchmove. Shouldn't we follow this?
|
||
Comment 1•5 years ago
|
||
Yeah, I think so.
IIRC also kats was in favor of making the change.
|
||
Comment 2•5 years ago
|
||
Sounds good to me
|
|
||
Comment 3•5 years ago
|
||
FWIW, I couldn't immediately find any telemetry telling whether this change could improve performance.
|
||
Updated•5 years ago
|
|
|
||
Comment 4•5 years ago
|
||
FWIW, Chrome has at least some regressions https://bugs.chromium.org/p/chromium/issues/detail?id=931466
|
|
||
Comment 5•5 years ago
|
||
And regressions with React https://github.com/facebook/react/issues/14856
|
Assignee | |
Comment 6•4 years ago
|
||
I just found a website (https://www.ashler.design/) which scrolls super-slow in Firefox because of this.
|
|
Assignee | |
Comment 7•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 8•4 years ago
|
||
This turned out to not be the root cause for that broken site, but I wrote the
code so... I enabled it on Nightly only to see if there's fallout, I don't think
we need to ship this in the near term, your call.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2bbbaccb0d06 Make dom.event.default_to_passive_touch_listeners a static pref. r=smaug https://hg.mozilla.org/integration/autoland/rev/98bafb894b5d Make wheel events passive by default on Nightly. r=smaug
|
||
Comment 10•4 years ago
|
||
Backed out 2 changesets (bug 1526725) as per dev's request
Push that was backed out:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=98bafb894b5d09731458584a95e955c9dbc4cace
Backout:
https://hg.mozilla.org/integration/autoland/rev/ecb7e12f7e05e1b22a69c04ada0885790f7eafa1
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 11•4 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f1654b5e2746 Make dom.event.default_to_passive_touch_listeners a static pref. r=smaug https://hg.mozilla.org/integration/autoland/rev/dd177138d6d2 Make wheel events passive by default on Nightly. r=smaug
|
|
||
Comment 12•4 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/bd3462eeb191 followup: Fix a test that's intermittently failing more often.
|
||
Comment 13•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f1654b5e2746
https://hg.mozilla.org/mozilla-central/rev/dd177138d6d2
https://hg.mozilla.org/mozilla-central/rev/bd3462eeb191
|
||
Updated•4 years ago
|
|
||
Comment 14•4 years ago
|
||
Looks like this change is only enabled on nightly, unless there's another bug already fixed to enable it for release builds (in which case it should be linked to this bug for us to find it). Please make sure the bug to enable it by default is marked DDN. Thanks!
|
|
||
Comment 15•4 years ago
|
||
Noted this change on https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#DOM.
Description
•