Closed
Bug 1527200
Opened 5 years ago
Closed 5 years ago
Preferences tab sometimes shows "undefined" instead of "General"
Categories
(Thunderbird :: Preferences, enhancement)
Thunderbird
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 67.0
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
Attachments
(1 file)
|
1.33 KB,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
It looks like we're trying to read the label property before the prefpane binding is loaded. Fortunately we already have that information in an attribute.
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #9043180 -
Flags: review?(richard.marti)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9043180 [details] [diff] [review] 1527200-prefpane-label-1.diff I saw the "undefined" only one time before. So can't be sure the patch fixed it but you know what you are doing. So r+ ;-)
Attachment #9043180 -
Flags: review?(richard.marti) → review+
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a112a8348c08
Read prefpane labels from their attribute, not their binding. r=Paenglab
|
||
Comment 4•5 years ago
|
||
Does that need to go to TB 66 beta?
Target Milestone: --- → Thunderbird 67.0
You need to log in
before you can comment on or make changes to this bug.
Description
•