152786 - The framework of new event interface between nsIAccessible and ATK

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Kyle Yuan]

We need more event constants and structs to support ATK events.

The implementations will be distinguished from Windows code by a compile 
switch, except the constants' definition.

Comment 1

[Kyle Yuan]

Attachment: defined new constants and structs, add one more argument in nsIAccessibleEventListener::HandleEvent

This framework code is shared with both Windows and ATK.
We will split the impl code by #ifdef XP_UNIX/#endif block to avoid affecting 
current MSAA event code.

Aaron, could you take a look at this patch?

Comment 2

[Aaron Leventhal]

Comment on attachment 88395 [details] [diff] [review]
defined new constants and structs, add one more argument in nsIAccessibleEventListener::HandleEvent

r=aaronl, although MSAA uses   const unsigned long EVENT_REORDER	    =
0x8004;
to indicate the children of an object have changed. That sounds like it lines
up with your EVENT_CHILDREN_CHANGE. We haven't implemented EVENT_REORDER yet
(see bug 149654), so we'll want to base it off of your implementation when you
have it.  Will you consider naming yours EVENT_REORDER?

Comment 3

[Kyle Yuan]

I plan to add a ATK_ prefix to each event, such as EVENT_ATK_TEXT_CHANGE, etc.
because I saw that you added much event constants in bug 153196. That may cause 
more confusing.
We have EVENT_TABLE_ROW_REORDER and EVENT_TABLE_COLUMN_REORDER that only work 
for table (bug 152780). 
ATK requests 7 vital events must be implemented: focus_event (done), 
state_change (almost done), selection_changed, text_changed, text_caret_moved 
(almost done), text_selection_changed and children_changed. We prepare to 
implement selection_changed, text_changed and text_selection_changed firstly 
and implement children_changed in the future.

Comment 4

[Kyle Yuan]

Attachment: new constants with EVENT_ATK_ prefix

Aaron, which one is better? Actually, we don't want to impl
EVENT_ATK_TABLE_XXXX in the near future. Leave them here just for further impl.

Comment 5

[Aaron Leventhal]

Comment on attachment 88910 [details] [diff] [review]
new constants with EVENT_ATK_ prefix

r=aaronl.

This is better, but will you use MSAA's EVENT_REORDER instead of
EVENT_ATK_CHILDREN_CHANGE?

Comment 6

[Kyle Yuan]

ok, we'll use EVENT_REORDER instead of EVENT_ATK_CHILDREN_CHANGE.

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 88910 [details] [diff] [review]
new constants with EVENT_ATK_ prefix

sr=jst

Comment 8

[Kyle Yuan]

checked in