1528045 - Add Windows 10 1809 to WindowsVersion.h

Status: RESOLVED FIXED

(Core :: MFBT, enhancement)

Description

[(No longer employed by Mozilla) Aaron Klotz]

This is build 17763.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Patch

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0043bbfe7eae069595775caf4f25b174febddf4
Bug 1528045: Add detection for Win10 1809 to WindowsVersion.h; r=froydnj

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b0043bbfe7ea

Comment 4

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Comment on attachment 9044010 [details] [diff] [review]
Patch

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: None
• User impact if declined: Needed for bug 1498973 (fix hidden panels unhiding in Windows 10 1809)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds a simple inline function that is only called in bug 1498973
• String changes made/needed:

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9044010 [details] [diff] [review]
Patch

OK for uplift for the RC build.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/61bc653da5a9