Closed Bug 1528106 Opened 5 years ago Closed 4 years ago

Disable `qe-verify` flag

Categories

(bugzilla.mozilla.org :: Administration, task)

Product:
bugzilla.mozilla.org
Component:
Administration
Version:
Production
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: emceeaich, Assigned: emceeaich)

References

Details

As written now, qe-verify is a Bugzilla flag:

  • ? ➜ request to assess whether the bug should be tested manually
    • ➜ request to verify the bug manually
  • – ➜ the bug will not/can not be verified manually

But the flag does not account for when a bug has been accepted for manual verification.

Should the definitions be updated to:

  • ?, request to verify
  • +, accepted and will be verified manually
  • -, not accepted or unable to verify manually (explanation in comments)

As a flag, we don't have the extra values to indicate if verification was completed and the outcome.

We could make the flag a tracking flag which would allow multiple values.

  • ?, request to verify
  • accepted, will be verified manually
  • rejected, will not/can not be verified manually
  • verified, QA has verified manually
  • failed, QA found defects while verifying

What (if anything) should we change here?

Flags: needinfo?(tmaity)
Flags: needinfo?(tgrabowski)
Flags: needinfo?(ryanvm)

I feel we should also consider "Blocked", QA cannot verify due to another open bug.

(In reply to Tania Maity (:tmaity) from comment #1)

I feel we should also consider "Blocked", QA cannot verify due to another open bug.

+1

Should it also be qa-verify instead of qe-verify?

I vote for qa-verify instead of qe-verify.

Flags: needinfo?(tmaity)

qa-verify:verified seems redundant to me with the status flags being set to verified (and more importantly, using status flags for it captures which versions the fix has actually been verified on). Maybe "complete" instead? Or we just have somewhat-duplicated metadata, doesn't seem like a particularly big deal one way or another.

Flags: needinfo?(ryanvm)

It looks good to me. I don't mind the qa-verify:verified status looking redundant. And let's go with qa-verify.

Flags: needinfo?(tgrabowski)

I'll need a plan for and some help migrating the old flags. Assigning this bug to my work queue.

Assignee: nobody → ehumphries
Blocks: 1541582

Emma, do you have a plan to make this change sometime soon? Otherwise the request in Bug 1541582 is valid so I’ll merge :MattN’s PR.

Flags: needinfo?(ehumphries)

I'd like to get this done, but I need to get developer time for the data migration.

Flags: needinfo?(ehumphries)

Tania, this got dropped on the floor. Do the changes described above make sense to do still?

Flags: needinfo?(tmaity)

yes, don't see any harm doing it.

Flags: needinfo?(tmaity)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Summary: Update definition of `qe-verify` values? → Disable `qe-verify` flag

Leaving the qe-verify field as-is.

File a new bug if changes to this flag are needed.

Resolution: FIXED → WONTFIX
You need to log in before you can comment on or make changes to this bug.