If an uplift request answers Yes to needing manual QA, the qe-verify flag should be set to '+', not '?'
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
People
(Reporter: MattN, Assigned: MattN)
References
(Regression)
Details
Attachments
(1 file)
See https://bugzilla.mozilla.org/show_bug.cgi?id=1538952#a777766_305228 where it was incorrectly reset to '?'.
Definitions of the flag from the tooltip:
qe-verify: ? ➜ request to assess whether the bug should be tested manually
qe-verify: + ➜ request to verify the bug manually
qe-verify: – ➜ the bug will not/can not be verified manually
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Looks like the definition of the qe-verify
flag is about to change. See Bug 1528106.
Assignee | ||
Comment 3•6 years ago
|
||
IMO the behaviour seen in https://bugzilla.mozilla.org/show_bug.cgi?id=1538952#a777766_305228 (where the flag was reset) is a regression so not sure why you removed bug 1527178 from the regressed by field.
(In reply to Kohei Yoshino [:kohei] (Bugzilla UX) (FxSiteCompat) from comment #2)
Looks like the definition of the
qe-verify
flag is about to change. See Bug 1528106.
That's been stalled for a month so not worth the regression in the meantime IMO since it's a 1 character fix to change in that bug.
Very true, let's make that change.
Comment 5•6 years ago
|
||
This is not a regression because Bug 1527178 is a new feature. I’ll merge the PR now.
Comment 6•6 years ago
|
||
Merged to master.
Assignee | ||
Comment 7•6 years ago
|
||
(In reply to Kohei Yoshino [:kohei] (Bugzilla UX) (FxSiteCompat) from comment #5)
This is not a regression because Bug 1527178 is a new feature. I’ll merge the PR now.
New features can cause regressions so that argument doesn't make much sense. I could have summarized the bug as "qe-verify flag gets reset to '?' when I request an uplift with QA verification"… would you then agree that this is a regression?
Comment 8•6 years ago
|
||
Now I understand your point! (and the Regressed by field I’ve added works great)
Updated•6 years ago
|
Description
•