1528146 - Make non-initial about:blank fire document-element-inserted notifications

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

I need this for bug 1489308 to fix how webextensions interact with about:blank.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1528146. Fix how web extensions are injected into about:blank. r=kmag

The basic idea is to make non-initial about:blank fire
document-element-inserted notifications just like every other document. We
then ensure that there's a notification (initial-document-element-inserted)
that only gets fired once per window for documents that are in a window. This
notification is what webextensions use to inject into the document.

The old setup which injected into about:blank when its global is created gets
removed in favor of injecting the same way as into every other document.

The changes to Document.cpp are fixing a bug in the "block the parser" stuff
webextensions do. For about:blank, the blocking happens at a point when the
parser really has nothing else to parse (since it's parsing the empty string).
So the blocking is a no-op. But we do want to prevent DOMContentLoaded firing,
because otherwise the "end of document" scripts could run before we finish
doing the "beginning of document" work in webextensions. So we want to make
sure we block DOMContentLoaded, not just the load event.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/367ca1e16853
Fix how web extensions are injected into about:blank.  r=kmag

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/367ca1e16853

Comment 4

[Cristina Coroiu [:ccoroiu]]

Backout requested by igoldan
Backout: https://hg.mozilla.org/mozilla-central/rev/98c743692a8494dbd609abe2f96b8297f777cad6

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e657fe2ca2a3
Fix how web extensions are injected into about:blank.  r=kmag

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/e657fe2ca2a3

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/e657fe2ca2a3