Open Bug 1528285 (omt-networking) Opened 5 years ago Updated 9 months ago

[meta] Allow call of AsyncOpen and OnStart/OnStopRequest off the main thread

Categories

(Core :: Networking: HTTP, enhancement, P2)

enhancement

Tracking

()

Performance Impact medium
Tracking Status
firefox67 --- affected

People

(Reporter: mayhemer, Unassigned)

References

(Depends on 2 open bugs, Blocks 5 open bugs)

Details

(Keywords: meta, perf:pageload, Whiteboard: [necko-triaged])

I believe there are consumers that can accept OnStartRequest and OnStopRequest on non-main thread(s). This is definitely needed to make bug 1505493 reality (CacheFileInputStream::NotifyListener triggers also OnStartRequest, so it can't be that simply moved to a background thread)

I meant to open this bug today. We want to move asyncOpen on the child process as well.

Summary: Allow optional retarget of OnStart/OnStopRequest as well → Allow call of AsyncOpen and OnStart/OnStopRequest of the main thread

\o/

Summary: Allow call of AsyncOpen and OnStart/OnStopRequest of the main thread → Allow call of AsyncOpen and OnStart/OnStopRequest off the main thread
Priority: -- → P2
Whiteboard: [necko-triaged]
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
Blocks: 1510262

Valentin, is your work on URI off main thread fur enough that we can do this?

Flags: needinfo?(valentin.gosu)

(In reply to Dragana Damjanovic [:dragana] from comment #3)

Valentin, is your work on URI off main thread fur enough that we can do this?

Ooops, missed this ni. Yes, the OMT URI work is officially complete in Fx 69

Flags: needinfo?(valentin.gosu)
Assignee: dd.mozilla → juhsu

Getting this would likely be a significant help with e10s network requests, especially on Fenix

Whiteboard: [necko-triaged] → [necko-triaged][qf]
Alias: omt-asyncopen
Whiteboard: [necko-triaged][qf] → [necko-triaged][qf:p2:pageload]
See Also: → 1560090
Summary: Allow call of AsyncOpen and OnStart/OnStopRequest off the main thread → [meta] Allow call of AsyncOpen and OnStart/OnStopRequest off the main thread
Depends on: 1633935
Depends on: 1639072
Depends on: omt-content
Depends on: 1645901
Depends on: 1646592
Depends on: 1652189

Hi Junior, bug 1639433 and bug 1639072 are now P5, what does this mean for this bugs (and others that depend on it) ?

Flags: needinfo?(juhsu)

Hello Jens,
Thanks for raising this. I adjust the priority and the dependency.

After discussion, we figure out OMT asyncOpen has too many dependencies, which could be no performance gain for most of the cases.
For workers, which is the most motivator, has a different plan in bug 1351231.

bug 1639072 comment 5 has a more detailed description.

Flags: needinfo?(juhsu)
Assignee: CuveeHsu → nobody
Status: ASSIGNED → NEW
No longer blocks: 1351231
Depends on: 1738585
Performance Impact: --- → P2
Keywords: perf:pageload
Whiteboard: [necko-triaged][qf:p2:pageload] → [necko-triaged]
Alias: omt-asyncopen → omt-networking
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.