Closed Bug 1528323 Opened 7 months ago Closed 7 months ago

Make replaceTrack async even when transceiver is not associated

Categories

(Core :: WebRTC: Signaling, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: bwc, Assigned: bwc)

References

Details

Attachments

(4 files)

See https://searchfox.org/mozilla-central/rev/cf90c6a36619c8b86cd257c5dc661ed48b94fae6/dom/media/PeerConnection.js#1895

The spec has subsequently become a little more straightforward.

This is causing some of the stability problems over in bug 1524642.

Assignee: nobody → docfaraday

Marking P2 because it is impairing wpt sync.

Rank: 15
Priority: -- → P2

Ping for re-review.

Flags: needinfo?(jib)
Flags: needinfo?(jib)
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e1b06db7e2c6
Part 1: Bring replaceTrack up to spec in terms of async and timing. r=jib
https://hg.mozilla.org/integration/autoland/rev/be1db93b9ba7
Part 1.1: Fix bug in _queueWithClosedCheck where |this| did not refer to the PeerConnection. r=jib
https://hg.mozilla.org/integration/autoland/rev/4ec8d35bbefc
Part 2: Mark some wpt as passing, and fix some others. Also fix a mochitest. r=jib
https://hg.mozilla.org/integration/autoland/rev/e5644fcedb19
Part 3: Fix a mochitest that was abandoning its promises, and not noticing exceptions as a result. r=jib

Backed out 4 changesets (Bug 1528323) for linting opt on a CLOSED TREE DONTBUILD

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=e5644fcedb190f861720b65572f7ca31a63fc321

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=230780204&repo=autoland&lineNumber=292

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=bd76311c316a72934e367578dea3c433967a2bad

[task 2019-02-27T15:30:45.569Z] creating build
[task 2019-02-27T15:30:45.569Z] creating build/temp.linux-x86_64-2.7
[task 2019-02-27T15:30:45.569Z] creating build/temp.linux-x86_64-2.7/psutil
[task 2019-02-27T15:30:45.569Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2019-02-27T15:30:45.569Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2019-02-27T15:30:45.569Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_linux.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o
[task 2019-02-27T15:30:45.569Z] creating build/lib.linux-x86_64-2.7
[task 2019-02-27T15:30:45.569Z] creating build/lib.linux-x86_64-2.7/psutil
[task 2019-02-27T15:30:45.569Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so
[task 2019-02-27T15:30:45.569Z] building 'psutil._psutil_posix' extension
[task 2019-02-27T15:30:45.569Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2019-02-27T15:30:45.569Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2019-02-27T15:30:45.569Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2019-02-27T15:30:45.569Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2019-02-27T15:30:45.569Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-02-27T15:30:45.569Z]
[task 2019-02-27T15:30:45.569Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-02-27T15:36:21.054Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/dom/media/PeerConnection.jsm:590:42 | A space is required after ','. (comma-spacing)
[taskcluster 2019-02-27 15:36:21.642Z] === Task Finished ===
[taskcluster 2019-02-27 15:36:21.643Z] Unsuccessful task run with exit code: 1 completed in 633.974 seconds

Flags: needinfo?(docfaraday)

Ok, that's interesting. moz-phab submit did not update part 1 for some reason. Trying again...

Flags: needinfo?(docfaraday)
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2c753e0e871
Part 1: Bring replaceTrack up to spec in terms of async and timing. r=jib
https://hg.mozilla.org/integration/autoland/rev/c998f84e7697
Part 1.1: Fix bug in _queueWithClosedCheck where |this| did not refer to the PeerConnection. r=jib
https://hg.mozilla.org/integration/autoland/rev/f6a0bad24920
Part 2: Mark some wpt as passing, and fix some others. Also fix a mochitest. r=jib
https://hg.mozilla.org/integration/autoland/rev/e4e4e4a15fc1
Part 3: Fix a mochitest that was abandoning its promises, and not noticing exceptions as a result. r=jib
https://hg.mozilla.org/projects/oak/rev/e1b06db7e2c61a57616a14fb4e0bbf4cb62149ac
Bug 1528323 - Part 1: Bring replaceTrack up to spec in terms of async and timing. r=jib

https://hg.mozilla.org/projects/oak/rev/be1db93b9ba737fe549c10cd7d762d0cec87da10
Bug 1528323 - Part 1.1: Fix bug in _queueWithClosedCheck where |this| did not refer to the PeerConnection. r=jib

https://hg.mozilla.org/projects/oak/rev/4ec8d35bbefce1c9dc0feccd1165933f831c855f
Bug 1528323 - Part 2: Mark some wpt as passing, and fix some others. Also fix a mochitest. r=jib

https://hg.mozilla.org/projects/oak/rev/a2c753e0e87199ffbfb0f3754f9f951010051dfe
Bug 1528323 - Part 1: Bring replaceTrack up to spec in terms of async and timing. r=jib

https://hg.mozilla.org/projects/oak/rev/c998f84e769717ef32c9ef956bab4ab3645488b8
Bug 1528323 - Part 1.1: Fix bug in _queueWithClosedCheck where |this| did not refer to the PeerConnection. r=jib

https://hg.mozilla.org/projects/oak/rev/f6a0bad24920fdb2b84b4391a98e7a16cec9d93b
Bug 1528323 - Part 2: Mark some wpt as passing, and fix some others. Also fix a mochitest. r=jib

https://hg.mozilla.org/projects/oak/rev/e4e4e4a15fc124878f9dab7298350661afb7238d
Bug 1528323 - Part 3: Fix a mochitest that was abandoning its promises, and not noticing exceptions as a result. r=jib
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15640 for changes under testing/web-platform/tests
Upstream PR was closed without merging
You need to log in before you can comment on or make changes to this bug.