Add DataView methods for BigInt access

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: terpri, Assigned: terpri)

Tracking

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 months ago
No description provided.
Assignee

Updated

3 months ago
Assignee: nobody → robin
Blocks: 1456569
Assignee

Updated

3 months ago
Keywords: checkin-needed

Comment 2

3 months ago

Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/046ef8ec79cb
Add DataView methods for BigInt access r=wingo,jwalden

Keywords: checkin-needed

Backed out changeset 046ef8ec79cb (bug 1528582) for mochitest failures in js/xpconnect/tests/chrome/test_xrayToJS.xul

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=229320493&repo=autoland&lineNumber=2432

INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | key3 cannot be deleted
[task 2019-02-19T23:00:28.738Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | key4 can be deleted
[task 2019-02-19T23:00:28.739Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | key5 cannot be deleted
[task 2019-02-19T23:00:28.740Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Xrayed Proxy constructor should not have any properties
[task 2019-02-19T23:00:28.741Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Proxy.prototype should not be set
[task 2019-02-19T23:00:28.742Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Proxy.reflect is not set
[task 2019-02-19T23:00:28.743Z] 23:00:28 INFO - Buffered messages finished
[task 2019-02-19T23:00:28.744Z] 23:00:28 INFO - TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_xrayToJS.xul | A property on the DataView prototype has changed! You need a security audit from an XPConnect peer - got "["buffer", "byteLength", "byteOffset", "constructor", "getBigInt64", "getBigUint64", "getFloat32", "getFloat64", "getInt16", "getInt32", "getInt8", "getUint16", "getUint32", "getUint8", "setBigInt64", "setBigUint64", "setFloat32", "setFloat64", "setInt16", "setInt32", "setInt8", "setUint16", "setUint32", "setUint8"]", expected "["buffer", "byteLength", "byteOffset", "constructor", "getFloat32", "getFloat64", "getInt16", "getInt32", "getInt8", "getUint16", "getUint32", "getUint8", "setFloat32", "setFloat64", "setInt16", "setInt32", "setInt8", "setUint16", "setUint32", "setUint8"]"
[task 2019-02-19T23:00:28.745Z] 23:00:28 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:320:16
[task 2019-02-19T23:00:28.746Z] 23:00:28 INFO - testXray@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:418:5
[task 2019-02-19T23:00:28.748Z] 23:00:28 INFO - testDataView@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:1061:5
[task 2019-02-19T23:00:28.749Z] 23:00:28 INFO - go@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:160:5
[task 2019-02-19T23:00:28.750Z] 23:00:28 INFO - onload@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:1:1
[task 2019-02-19T23:00:28.752Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | A symbol-keyed property on the DataView prototype has been changed! You need a security audit from an XPConnect peer
[task 2019-02-19T23:00:28.753Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Need something to test
[task 2019-02-19T23:00:28.755Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Xray proto is correct
[task 2019-02-19T23:00:28.756Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Proto accessors agree
[task 2019-02-19T23:00:28.758Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | proto proto is correct
[task 2019-02-19T23:00:28.760Z] 23:00:28 INFO - Running tests for property: buffer
[task 2019-02-19T23:00:28.761Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | proto should have the property 'buffer' as own
[task 2019-02-19T23:00:28.763Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | instance should not have the property 'buffer' as own
[task 2019-02-19T23:00:28.765Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Methods from Xrays are functions
[task 2019-02-19T23:00:28.766Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Methods from Xrays are local
[task 2019-02-19T23:00:28.769Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | instanceof works on methods from Xrays
[task 2019-02-19T23:00:28.770Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Holder caching works properly
[task 2019-02-19T23:00:28.772Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Proto props resolve on the instance
[task 2019-02-19T23:00:28.774Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Function.length identical
[task 2019-02-19T23:00:28.775Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Xray and local method results stringify identically
[task 2019-02-19T23:00:28.777Z] 23:00:28 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Xray and waived method results stringify identically

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=046ef8ec79cba0d11106105e4dc28b8b538f8f8c

Backout:
https://hg.mozilla.org/integration/autoland/rev/4ce64be6418df15cd64d65edcd331e86e67204d1

Flags: needinfo?(robin)
Assignee

Comment 4

3 months ago

the method definitions should be skipped when bigint is not enabled as a compile option

this will also need an audit once the default setting changes, but the methods shouldn't be visible to the testcase at all yet

Flags: needinfo?(robin)

Comment 6

3 months ago

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ed6150abbe58
Add DataView methods for BigInt access r=wingo,jwalden

Keywords: checkin-needed

Comment 7

3 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.