Closed Bug 1528593 Opened 2 years ago Closed 1 year ago

Rename UrlbarInput::value getter to untrimmedValue and textValue to value

Categories

(Firefox :: Address Bar, task, P3)

task
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox67 --- wontfix
firefox70 --- fixed

People

(Reporter: dao, Assigned: harry)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The current textValue getter is usually what consumers want, so once we've got rid of the legacy binding we should rename this to value for convenience.

Blocks: 1551227
No longer depends on: quantumbar
Points: --- → 2

This will be a bit more involved as it requires updating many tests and other code.

Points: 2 → 3
Type: enhancement → task
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Attachment #9085856 - Attachment description: Bug 1528593 - Rename UrlbarInput::value getter to untrimmedValue and textValue to value. r?adw → Bug 1528593 - Rename UrlbarInput::value getter to untrimmedValue and textValue to value. r?dao
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/54527f838bf5
Rename UrlbarInput::value getter to untrimmedValue and textValue to value. r=dao
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Regressions: 1627378
You need to log in before you can comment on or make changes to this bug.