1627378 - Address bar doesn't remain highlighted when clicked immediately following opening new window

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Chester]

Attachment: firefox-urlbar-bug_03-04-20.mov

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

Steps to reproduce:

1: Start Firefox or open a new window
2: Immediately click on the address bar

Actual results:

Actual results:

URL in address bar gets briefly highlighted before reverting to non-highlighted state with the cursor at the beginning

Expected results:

Expected results:

URL in address bar is and remains highlighted

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fb816f83f64cd253d7ece0ae809f6be8d5b88aba&tochange=54527f838bf5d344d53f5313391e3fe959050c2a

Comment 3

[Dão Gottwald [:dao]]

(In reply to Alice0775 White from comment #2)

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fb816f83f64cd253d7ece0ae809f6be8d5b88aba&tochange=54527f838bf5d344d53f5313391e3fe959050c2a

This is weird, bug 1528593 just renamed properties and shouldn't have changed behavior. Maybe there's some code using value that should have been updated to untrimmedValue? Harry, could you please take a look?

Comment 4

[Harry Twyford]

Attachment: Bug 1627378 - Rename gURLBar.value getter missed in bug 1528593. r?dao

Comment 5

[Harry Twyford]

This bug is unrelated to the address bar update. It affects the old address bar as well.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7450bc82c694
Rename gURLBar.value getter missed in bug 1528593. r=dao

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/7450bc82c694

Comment 8

[Harry Twyford]

Comment on attachment 9140146 [details]
Bug 1627378 - Rename gURLBar.value getter missed in bug 1528593. r?dao

Beta/Release Uplift Approval Request

• User impact if declined: Annoying UI bug where the URL could become un-highlighted.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-line change to Urlbar JS. The scope of possible regressions is very small and nothing has been reported so far.
• String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9140146 [details]
Bug 1627378 - Rename gURLBar.value getter missed in bug 1528593. r?dao

Fixes an annoying UI glitch. Approved for 76.0b5.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c902a07fd395

Comment 11

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

We could not reproduce this issue on any of our machines.
Alice, could you please help us confirm this fix?

Thank you!

Comment 12

[Alice0775 White]

I can reproduce the issue on Nightly77.0a1(20200414094457) and Firefox76.0b4 Windows10.
And I verified that the problem is no longer reproduce on Nightly77.0a1(20200416094846) and Firefox76.0b5.