1528622 - use one notification when sending large number of tabs

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P2)

Description

[Asa Dotzler [:asa]]

When I send a large group of tabs from one machine to another, I get a Windows notification for every tab. We should collapse all those notifications into one for large numbers of tabs.

Comment 1

[Ryan Kelly [:rfkelly]]

+Alex for PM context and prioritization.

Sending multiple tabs is currently implemented by just sending each tab individually, which explains why we get multiple notifications. I see two ways we could address this: expand the send-tab transfer format to explicitly support multiple tabs (a big effort with b/w compat concerns) or add some debouncing logic in the thing that shows the notifications (smaller, but has to be done separately for each send-tab client).

Comment 2

[Mark Hammond [:markh] [:mhammond]]

FWIW, the "old" way of sending tabs did explicitly support this - the notification is displayed at https://searchfox.org/mozilla-central/rev/ee40541496d3ad738097eebadaf4965ca1343b7a/browser/components/BrowserGlue.jsm#2862, which handles the "one tab" vs "many tabs" differently. The old system would send many but the push-based system only ever sends 1. We should probably consider this a regression.

Comment 3

[Alex Davis [:adavis]]

To Mark's point, this feels like a regression because we did group them previously. IMO, seems like the person who introduced the regression should resolve that.

Comment 4

[Ryan Kelly [:rfkelly]]

Alrighty. Seems like :eoger is most likely to have a sense of how we can resolve this - Ed, thoughts?

FWIW, this is also the sort of thing that should appear in the "this is how send-tab should work on Fenix" document we've been talking about, or we risk repeating the experience in that integration as well.

Comment 5

[Edouard Oger [:eoger]]

Attachment: Bug 1528622 - Debounce FxA Send Tab commands.

Comment 6

[Edouard Oger [:eoger]]

I've posted a patch that should help reproduce the older behaviour.
As Ryan said, incoming tabs grouping never was an explicit product requirement, so maybe we should make it for our Fenix implementation.

Loosely related but important too: In the future, we should also evolve our schema to handle multiple tabs being sent at the same time.

Comment 7

[Pascal Chevrel:pascalc]

Edouard, do you think this will land before the final merge to beta next week? If not, should we track it for a potential beta uplift? Thanks

Comment 8

[Edouard Oger [:eoger]]

Yes I think we can make it before next week. I'll ping Mark on Slack today

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fddb40ccfe5a
Debounce FxA Send Tab commands. r=markh,rfkelly

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/fddb40ccfe5a