Closed Bug 1528622 Opened 1 year ago Closed 1 year ago

use one notification when sending large number of tabs

Categories

(Firefox :: Sync, defect, P2)

All
Windows
defect

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- fixed

People

(Reporter: asa, Assigned: eoger)

References

(Depends on 1 open bug)

Details

(Keywords: regression, Whiteboard: [3/6] patch waiting for review)

Attachments

(1 file)

When I send a large group of tabs from one machine to another, I get a Windows notification for every tab. We should collapse all those notifications into one for large numbers of tabs.

+Alex for PM context and prioritization.

Sending multiple tabs is currently implemented by just sending each tab individually, which explains why we get multiple notifications. I see two ways we could address this: expand the send-tab transfer format to explicitly support multiple tabs (a big effort with b/w compat concerns) or add some debouncing logic in the thing that shows the notifications (smaller, but has to be done separately for each send-tab client).

FWIW, the "old" way of sending tabs did explicitly support this - the notification is displayed at https://searchfox.org/mozilla-central/rev/ee40541496d3ad738097eebadaf4965ca1343b7a/browser/components/BrowserGlue.jsm#2862, which handles the "one tab" vs "many tabs" differently. The old system would send many but the push-based system only ever sends 1. We should probably consider this a regression.

Keywords: regression
Flags: needinfo?(adavis)

To Mark's point, this feels like a regression because we did group them previously. IMO, seems like the person who introduced the regression should resolve that.

Flags: needinfo?(adavis)

Alrighty. Seems like :eoger is most likely to have a sense of how we can resolve this - Ed, thoughts?

FWIW, this is also the sort of thing that should appear in the "this is how send-tab should work on Fenix" document we've been talking about, or we risk repeating the experience in that integration as well.

Flags: needinfo?(eoger)
Flags: needinfo?(eoger)

I've posted a patch that should help reproduce the older behaviour.
As Ryan said, incoming tabs grouping never was an explicit product requirement, so maybe we should make it for our Fenix implementation.

Loosely related but important too: In the future, we should also evolve our schema to handle multiple tabs being sent at the same time.

Assignee: nobody → eoger
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [3/6] patch waiting for review

Edouard, do you think this will land before the final merge to beta next week? If not, should we track it for a potential beta uplift? Thanks

Flags: needinfo?(eoger)

Yes I think we can make it before next week. I'll ping Mark on Slack today

Flags: needinfo?(eoger)
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fddb40ccfe5a
Debounce FxA Send Tab commands. r=markh,rfkelly
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Type: enhancement → defect
Depends on: 1561473
You need to log in before you can comment on or make changes to this bug.