1561473 - Debouncing of FxA messages doesn't work when a collection is sent from Fenix

Status: NEW

(Firefox :: Sync, defect, P3)

Description

[Mark Hammond [:markh] [:mhammond]]

I'm sure this isn't Fenix specific, but STR:

• Have a Fenix collection with multiple tabs, send the collection to desktop

Expected:

• A single notification saying multiple tabs were received.

Actual:

• 2 individual notifications which are shown at almost the same time, one obscuring the other.

This was supposed to have been fixed in bug 1528622. An edited log is below which clearly shows the tabs being handled individually.

1561511666885   FirefoxAccounts DEBUG   FxAccountsPush loading service
1561511666886   FirefoxAccounts DEBUG   FxAccountsPush initialized
1561511666889   FirefoxAccounts TRACE   observed topic=push-message, data=chrome://fxa-device-update, subject=[xpconnect wrapped nsISupp
1561511666889   FirefoxAccounts TRACE   FxAccountsPushService _onPushMessage
1561511666890   FirefoxAccounts DEBUG   push command: fxaccounts:command_received
1561511666890   FirefoxAccounts INFO    Polling device commands.
1561511666892   Services.Common.RESTRequest     DEBUG   GET request to https://api.accounts.firefox.com/v1/account/device/commands?index
1561511667124   Services.Common.RESTRequest     DEBUG   GET https://api.accounts.firefox.com/v1/account/device/commands?index=2871353 20
1561511667124   Hawk    DEBUG   (Response) /account/device/commands?index=2871353: code: 200 - Status text: OK
1561511667126   FirefoxAccounts INFO    Handling 1 messages
1561511667128   Services.Common.RESTRequest     DEBUG   GET request to https://api.accounts.firefox.com/v1/account/devices
1561511667322   Services.Common.RESTRequest     DEBUG   GET https://api.accounts.firefox.com/v1/account/devices 200
1561511667323   Hawk    DEBUG   (Response) /account/devices: code: 200 - Status text: OK
1561511667326   FirefoxAccounts INFO    Tab received with FxA commands: Foobar - Wikipedia from Firefox Preview.
1561511667331   Sync.Engine.Tabs.Tracker        TRACE   onTab event: TabOpen
1561511667331   Sync.SyncScheduler      TRACE   Handling weave:engine:score:updated
1561511667375   Sync.Engine.Tabs.Tracker        TRACE   Registering tab listeners in window
1561511667448   FirefoxAccounts TRACE   observed topic=push-message, data=chrome://fxa-device-update, subject=[xpconnect wrapped nsISupp
1561511667449   FirefoxAccounts TRACE   FxAccountsPushService _onPushMessage
1561511667449   FirefoxAccounts DEBUG   push command: fxaccounts:command_received
1561511667449   FirefoxAccounts INFO    Polling device commands.
1561511667451   Services.Common.RESTRequest     DEBUG   GET request to https://api.accounts.firefox.com/v1/account/device/commands?index
1561511667649   Sync.Engine.History.Tracker     TRACE   'page-visited': https://en.m.wikipedia.org/wiki/Foobar
1561511667650   Sync.Engine.History.Tracker     TRACE   Adding changed ID: 6Mh5n-yneS7o, 1561511667.65
1561511667650   Sync.SyncScheduler      TRACE   Handling weave:engine:score:updated
1561511667659   Services.Common.RESTRequest     DEBUG   GET https://api.accounts.firefox.com/v1/account/device/commands?index=2871354 20
1561511667660   Hawk    DEBUG   (Response) /account/device/commands?index=2871354: code: 200 - Status text: OK
1561511667661   FirefoxAccounts INFO    Handling 1 messages
1561511667663   Services.Common.RESTRequest     DEBUG   GET request to https://api.accounts.firefox.com/v1/account/devices
1561511667753   Sync.SyncScheduler      TRACE   There's already a sync scheduled in 3584247 ms.
1561511667753   Sync.SyncScheduler      TRACE   Ignoring scheduling request for next sync in 3600000 ms.
1561511667861   Services.Common.RESTRequest     DEBUG   GET https://api.accounts.firefox.com/v1/account/devices 200
1561511667861   Hawk    DEBUG   (Response) /account/devices: code: 200 - Status text: OK
1561511667866   FirefoxAccounts INFO    Tab received with FxA commands: wwtf - Google Search from Firefox Preview.
1561511667869   Sync.Engine.Tabs.Tracker        TRACE   onTab event: TabOpen
1561511667870   Sync.SyncScheduler      TRACE   Handling weave:engine:score:updated

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:markh, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

To clarify, from the above log, we have:

1561511667126 FirefoxAccounts INFO Handling 1 messages
1561511667126 FirefoxAccounts INFO Handling 1 messages

but expect:

1561511667126 FirefoxAccounts INFO Handling 2 messages