1528649 - Remove the context parameter from nsInputStreamPump::AsyncRead

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P3)

Description

[Masatoshi Kimura [:emk]]

Because it is not used anymore.

Comment 1

[hgallagher]

Hi, I'll take this on 👍

Comment 2

[hgallagher]

Attachment: Bug 1528649 - Remove context parameter from nsInputStreamPump::AsyncRead. r=jkt

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:hgallagher, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[hgallagher]

I'm not really sure what needs to happen, can the patch just be merged?

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Hi, I'm sorry we didn't get back to you about the patch.
Do you want to rebase it on the latest mozilla-central and resubmit it?

Comment 6

[hgallagher]

I've rebased, but I'm not really what to do next and the documentation isn't very helpful at all. I did a moz-phab submit but I don't think it did anything, is there some kind of force push like in git?

Comment 7

[Valentin Gosu [:valentin] (he/him)]

(In reply to hgallagher from comment #6)

I've rebased, but I'm not really what to do next and the documentation isn't very helpful at all. I did a moz-phab submit but I don't think it did anything, is there some kind of force push like in git?

That should upload the new patch. Did moz-phab give you an error? Can you try moz-phab self-update if it doesn't work? Or try reinstalling it completely? https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#setting-up-mozphab

Comment 8

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1528649 - Remove contex parameter from the remaining callsites r=michal

Comment 9

[hgallagher]

Attachment: Bug 1528649 - Remove context parameter from nsInputStreamPump::AsyncRead. r=valentin

Comment 10

[Sonia Singla :soniasingla]

Hi Valentin

Is this bug available?

Comment 11

[Valentin Gosu [:valentin] (he/him)]

Assignee hasn't responded in months.
Feel free to take it.

Comment 12

[Sonia Singla :soniasingla]

Attachment: Bug 1528649 - Remove the context parameter from nsInputStreamPump::AsyncRead. r=valentin

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/348ef4153d84
Remove the context parameter from nsInputStreamPump::AsyncRead. r=valentin,necko-reviewers

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/348ef4153d84