Closed Bug 1528744 Opened 5 years ago Closed 5 years ago

Port browser_urlbar_search.js / browser_urlbar_keyed_search.js to QuantumBar

Categories

(Firefox :: General, enhancement, P2)

Product:
Firefox
Component:
General
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: standard8, Assigned: adw)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file, 2 obsolete files)

Bug 1528744 - Port browser_urlbar_search.js and browser_urlbar_keyed_search.js to QuantumBar.
47 bytes, text/x-phabricator-request
Details | Review

We need to port browser_urlbar_search.js and browser_urlbar_keyed_search.js to work with QuantumBar.

Currently these can't be ported directly because the tests both use nsIAutoCompletePopup::invalidate (and possibly onResultsAdded) which aren't available in the new implementation.

Hence we need to figure out how they should work with the new implementation.

Assignee: nobody → adw
Status: NEW → ASSIGNED

Try push with only browser_urlbar_search.js converted so far: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f133a24f47375dc8871e9d37fae218ae34a20c4f

Attachment #9045491 - Attachment description: Bug 1528744 - Port browser_urlbar_search.js and browser_urlbar_keyed_search.js to QuantumBar. → Bug 1528744 - Port browser_urlbar_search.js to QuantumBar.

This builds on the other revision (D20598, the browser_urlbar_search.js port). The core test function in the two tests is very similar but not quite the same. I was able to modify the test function that I pulled out into head.js in the other revision to accommodate this keyed test, too.

Try looks good so far with browser_urlbar_search.js. Here's hopefully one last push with both tests ported:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b42d8b4cf81e9c2be7a434a402b102e104558482

Attachment #9045491 - Attachment is obsolete: true
Attachment #9046583 - Attachment is obsolete: true
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71dd92230a54
Port browser_urlbar_search.js and browser_urlbar_keyed_search.js to QuantumBar. r=Standard8,mconley

Backed out for permafails on browser_urlbar_keyed_search.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=71dd92230a54beb5037cf8ddef92b0f227653f93&searchStr=windows%2C7%2Cdebug%2Cmochitests%2Cwith%2Ce10s%2Ctest-windows7-32%2Fdebug-mochitest-browser-chrome-e10s-6%2Cm-e10s%28bc6%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=230931452&repo=autoland&lineNumber=17978

Backout link: https://hg.mozilla.org/integration/autoland/rev/1977f2af54696eef4969cced14f9497727207526

03:14:00 INFO - TEST-OK | browser/base/content/test/performance/browser_toolbariconcolor_restyles.js | took 1158ms
03:14:00 INFO - GECKO(4884) | ++DOCSHELL 0BF78C00 == 5 [pid = 5400] [id = {f9d97610-bd11-4f49-b716-379404a7fda0}]
03:14:00 INFO - GECKO(4884) | ++DOMWINDOW == 14 (089078D0) [pid = 5400] [serial = 43] [outer = 00000000]
03:14:00 INFO - GECKO(4884) | ++DOMWINDOW == 15 (0BF7A800) [pid = 5400] [serial = 44] [outer = 089078D0]
03:14:00 INFO - checking window state
03:14:00 INFO - Console message: [JavaScript Error: "listener[name] is not a function" {file: "resource:///modules/UrlbarController.jsm" line: 452}]
03:14:00 INFO - _notify@resource:///modules/UrlbarController.jsm:452:23
03:14:00 INFO - viewContextChanged@resource:///modules/UrlbarController.jsm:183:10
03:14:00 INFO - _on_TabSelect@resource:///modules/UrlbarInput.jsm:1110:21
03:14:00 INFO - handleEvent@resource:///modules/UrlbarInput.jsm:200:23
03:14:00 INFO - updateCurrentBrowser@chrome://browser/content/tabbrowser.js:1047:14
03:14:00 INFO - _setupEventListeners/<@chrome://browser/content/tabbrowser.js:4592:14
03:14:00 INFO - set selectedIndex@chrome://global/content/elements/tabbox.js:202:12
03:14:00 INFO - set selectedPanel@chrome://global/content/elements/tabbox.js:216:5
03:14:00 INFO - set_selectedIndex@chrome://global/content/bindings/tabbox.xml:176:15
03:14:00 INFO - set_selectedItem@chrome://global/content/bindings/tabbox.xml:201:39
03:14:00 INFO - set selectedTab@chrome://global/content/elements/tabbox.js:81:9
03:14:00 INFO - set selectedTab@chrome://browser/content/tabbrowser.js:266:5
03:14:00 INFO - _blurTab@chrome://browser/content/tabbrowser.js:3267:29
03:14:00 INFO - _beginRemoveTab@chrome://browser/content/tabbrowser.js:2967:10
03:14:00 INFO - removeTab@chrome://browser/content/tabbrowser.js:2875:15
03:14:00 INFO - Tester_waitForWindowsState@chrome://mochikit/content/browser-test.js:578:16
03:14:00 INFO - nextTest@chrome://mochikit/content/browser-test.js:902:10
03:14:00 INFO - asynctestScope/test_finish/<@chrome://mochikit/content/browser-test.js:1407:25
03:14:00 INFO - run@chrome://mochikit/content/browser-test.js:1344:9
03:14:00 INFO -
03:14:00 INFO - TEST-START | browser/base/content/test/performance/browser_urlbar_keyed_search.js
03:14:00 INFO - GECKO(4884) | [Parent 4428, Main Thread] WARNING: Suboptimal indexes for the SQL statement 0x18f4fe30 (http://mzl.la/1FuID0j).: file z:/build/build/src/storage/mozStoragePrivateHelpers.cpp, line 108
03:14:00 INFO - GECKO(4884) | --DOCSHELL 0B62A400 == 8 [pid = 6136] [id = {39f6d6fa-fcb3-4bf2-97d4-7ca48a9e6997}]
03:14:00 INFO - GECKO(4884) | --DOMWINDOW == 19 (08709D90) [pid = 6136] [serial = 28] [outer = 00000000] [url = about:blank]
03:14:00 INFO - GECKO(4884) | --DOCSHELL 087AA000 == 7 [pid = 6136] [id = {15d4f5d4-1f60-47af-8b29-c5dab17f3422}]
03:14:00 INFO - GECKO(4884) | --DOCSHELL 0B634000 == 6 [pid = 6136] [id = {b9853b7b-3f54-4942-ba60-a57faa3ebbd3}]
03:14:00 INFO - GECKO(4884) | --DOMWINDOW == 18 (08709A00) [pid = 6136] [serial = 22] [outer = 00000000] [url = about:blank]
03:14:00 INFO - GECKO(4884) | --DOMWINDOW == 17 (08709EC0) [pid = 6136] [serial = 25] [outer = 00000000] [url = about:blank]
03:14:00 INFO - GECKO(4884) | --DOMWINDOW == 16 (0870A250) [pid = 6136] [serial = 33] [outer = 00000000] [url = about:blank]
03:14:00 INFO - GECKO(4884) | --DOMWINDOW == 15 (08709FF0) [pid = 6136] [serial = 30] [outer = 00000000] [url = about:blank]
03:14:00 INFO - GECKO(4884) | --DOCSHELL 0B630C00 == 5 [pid = 6136] [id = {3398d240-3ab1-4aed-b79d-e6463ea862c2}]
03:14:00 INFO - GECKO(4884) | --DOCSHELL 0B630800 == 4 [pid = 6136] [id = {e39887a6-d8ea-441d-8316-7190ce6453ac}]
03:14:00 INFO - GECKO(4884) | --DOCSHELL 01560800 == 3 [pid = 6136] [id = {2dfb0212-7e5b-4c76-8abe-9a9cc54c5621}]
03:14:00 INFO - GECKO(4884) | --DOMWINDOW == 14 (087092E0) [pid = 6136] [serial = 41] [outer = 00000000] [url = about:blank]
03:14:00 INFO - GECKO(4884) | --DOMWINDOW == 13 (0870A380) [pid = 6136] [serial = 38] [outer = 00000000] [url = about:blank]
03:14:00 INFO - GECKO(4884) | --DOMWINDOW == 12 (08709B30) [pid = 6136] [serial = 36] [outer = 00000000] [url = about:blank]
03:14:00 INFO - GECKO(4884) | --DOCSHELL 0C888C00 == 2 [pid = 6136] [id = {31b5e27a-d277-4d99-985f-f19ff59ef435}]
03:14:00 INFO - GECKO(4884) | --DOCSHELL 0C881400 == 1 [pid = 6136] [id = {99abb682-1917-4b84-8cc6-e2bd31c05772}]
03:14:00 INFO - GECKO(4884) | ++DOCSHELL 1968B800 == 15 [pid = 4428] [id = {bb6f59b5-098c-4032-835c-afafd039e6c0}]
03:14:00 INFO - GECKO(4884) | ++DOMWINDOW == 29 (1A78FE30) [pid = 4428] [serial = 31] [outer = 00000000]
03:14:00 INFO - GECKO(4884) | ++DOMWINDOW == 30 (1A3F4400) [pid = 4428] [serial = 32] [outer = 1A78FE30]
03:14:00 INFO - GECKO(4884) | [Parent 4428, Lazy Idle] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file z:/build/build/src/widget/windows/WinUtils.cpp, line 1345
03:14:00 INFO - GECKO(4884) | [Parent 4428, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x805D0021: file z:/build/build/src/modules/libjar/nsJARChannel.cpp, line 993
03:14:00 INFO - GECKO(4884) | ++DOCSHELL 1B240C00 == 16 [pid = 4428] [id = {cf16b0f7-9820-4757-9616-9756661c508b}]
03:14:00 INFO - GECKO(4884) | ++DOMWINDOW == 31 (1A78FF60) [pid = 4428] [serial = 33] [outer = 00000000]
03:14:00 INFO - GECKO(4884) | ++DOCSHELL 01560800 == 2 [pid = 6136] [id = {f2de5cda-837e-49c7-90b5-289d33250d6a}]
03:14:00 INFO - GECKO(4884) | ++DOMWINDOW == 13 (087092E0) [pid = 6136] [serial = 46] [outer = 00000000]
03:14:01 INFO - GECKO(4884) | ++DOMWINDOW == 32 (1C0DC800) [pid = 4428] [serial = 34] [outer = 1A78FF60]
03:14:01 INFO - GECKO(4884) | ++DOMWINDOW == 14 (01567400) [pid = 6136] [serial = 47] [outer = 087092E0]
03:14:01 INFO - GECKO(4884) | ++DOMWINDOW == 15 (01568C00) [pid = 6136] [serial = 48] [outer = 087092E0]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 11 (0B0EDC00) [pid = 4648] [serial = 17] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 10 (0B05D400) [pid = 4648] [serial = 14] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 9 (07FB8400) [pid = 4648] [serial = 19] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 8 (0B058400) [pid = 4648] [serial = 22] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 7 (0B056000) [pid = 4648] [serial = 8] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 6 (0B059400) [pid = 4648] [serial = 11] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 5 (07FB9400) [pid = 4648] [serial = 5] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 4 (0086A800) [pid = 4648] [serial = 2] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 11 (085C5400) [pid = 3668] [serial = 19] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 10 (0B45D000) [pid = 3668] [serial = 22] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 9 (0C201C00) [pid = 3668] [serial = 17] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 8 (0B463800) [pid = 3668] [serial = 16] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 7 (00B6A400) [pid = 3668] [serial = 2] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 6 (0B45D800) [pid = 3668] [serial = 11] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 5 (085C5C00) [pid = 3668] [serial = 5] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 4 (0B45C800) [pid = 3668] [serial = 10] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 11 (0BE4F400) [pid = 2264] [serial = 20] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 10 (0BE54800) [pid = 2264] [serial = 22] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 9 (0CA02C00) [pid = 2264] [serial = 18] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 8 (0BE55400) [pid = 2264] [serial = 15] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 7 (0BE4E000) [pid = 2264] [serial = 9] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 6 (08B98800) [pid = 2264] [serial = 5] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 5 (0BE47C00) [pid = 2264] [serial = 6] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 4 (0BE51800) [pid = 2264] [serial = 12] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 8 (0B44C000) [pid = 4524] [serial = 14] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 7 (0B453400) [pid = 4524] [serial = 11] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 6 (084A9C00) [pid = 4524] [serial = 3] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 5 (0B451000) [pid = 4524] [serial = 9] [outer = 00000000] [url = about:blank]
03:14:01 INFO - GECKO(4884) | --DOMWINDOW == 4 (0B44DC00) [pid = 4524] [serial = 6] [outer = 00000000] [url = about:blank]
03:14:03 INFO - GECKO(4884) | [Parent 4428, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file z:/build/build/src/startupcache/StartupCacheUtils.cpp, line 157
03:14:03 INFO - TEST-INFO | started process screenshot
03:14:03 INFO - TEST-INFO | screenshot: exit 0
03:14:03 INFO - Buffered messages logged at 03:14:00
03:14:03 INFO - Entering test bound quantumbar
03:14:03 INFO - Buffered messages logged at 03:14:01
03:14:03 INFO - First opening, useAwesomebar=false
03:14:03 INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 869}]
03:14:03 INFO - Buffered messages finished
03:14:03 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_urlbar_keyed_search.js | uncaught exception - uncaught exception: out of memory at undefined
03:14:03 INFO - Stack trace:
03:14:03 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1665
03:14:03 INFO - OnErrorEventHandlerNonNullchrome://mochikit/content/tests/SimpleTest/SimpleTest.js:null:1645
03:14:03 INFO - chrome://mochikit/content/browser-test.js:Tester:400
03:14:03 INFO - chrome://mochikit/content/browser-harness.xul:createTester/</<:255
03:14:03 INFO - GECKO(4884) | JavaScript error: , line 0: uncaught exception: out of memory
03:14:03 INFO - Console message: [JavaScript Error: "uncaught exception: out of memory"]
03:14:03 INFO - Not taking screenshot here: see the one that was previously logged
03:14:03 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_urlbar_keyed_search.js | uncaught exception - uncaught exception: out of memory at undefined
03:14:03 INFO - Stack trace:
03:14:03 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1665
03:14:03 INFO - OnErrorEventHandlerNonNull*chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:null:1645
03:14:03 INFO - chrome://mochikit/content/browser-test.js:Tester:400
03:14:03 INFO - chrome://mochikit/content/browser-harness.xul:createTester/</<:255
03:14:03 INFO - GECKO(4884) | JavaScript error: , line 0: uncaught exception: out of memory
03:14:03 INFO - Console message: [JavaScript Error: "uncaught exception: out of memory"]
03:14:03 INFO - Not taking screenshot here: see the one that was previously logged

Flags: needinfo?(adw)

New patch queued for autoland.

Flags: needinfo?(adw)
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8b9a7f1d209
Port browser_urlbar_search.js and browser_urlbar_keyed_search.js to QuantumBar. r=Standard8,mconley

https://hg.mozilla.org/mozilla-central/rev/e8b9a7f1d209

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: